From c0295a249585ff6fa3d0a61bdf532dc6b0a6e653 Mon Sep 17 00:00:00 2001 From: Omar Abdelwahab Date: Wed, 12 Nov 2025 16:12:14 -0800 Subject: [PATCH] revert(debug): Remove temporary debug logging from resolver Removing the debug logging that was added to diagnose signature mismatch errors. The logging served its purpose - it helped us identify that the error was coming from api_recorder.py patched methods, not the actual provider implementations. With the root cause now fixed in api_recorder.py, this debug logging is no longer needed and can be safely removed to keep the code clean. --- src/llama_stack/core/resolver.py | 5 ----- 1 file changed, 5 deletions(-) diff --git a/src/llama_stack/core/resolver.py b/src/llama_stack/core/resolver.py index 625c7a771..8bf371fed 100644 --- a/src/llama_stack/core/resolver.py +++ b/src/llama_stack/core/resolver.py @@ -451,11 +451,6 @@ def check_protocol_compliance(obj: Any, protocol: Any) -> None: obj_params.discard("self") if not (proto_params <= obj_params): logger.error(f"Method {name} incompatible proto: {proto_params} vs. obj: {obj_params}") - logger.error(f"Provider: {obj.__class__.__name__} from module {obj.__class__.__module__}") - logger.error(f"Protocol signature: {proto_sig}") - logger.error(f"Object signature: {obj_sig}") - logger.error(f"Object method: {obj_method}") - logger.error(f"Object method's module: {inspect.getmodule(obj_method)}") missing_methods.append((name, "signature_mismatch")) else: # Check if the method has a concrete implementation (not just a protocol stub)