phoenix-oss/llama-stack-mirror
0
0
Fork 1
mirror of https://github.com/meta-llama/llama-stack.git synced 2025-07-24 21:29:53 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions

fix: honour deprecation of --config and --template (#2856)
Some checks failed
Coverage Badge / unit-tests (push) Failing after 1s
Details
Integration Tests / discover-tests (push) Successful in 3s
Details
Integration Auth Tests / test-matrix (oauth2_token) (push) Failing after 6s
Details
Vector IO Integration Tests / test-matrix (3.12, remote::chromadb) (push) Failing after 12s
Details
Test Llama Stack Build / build-single-provider (push) Failing after 6s
Details
Test Llama Stack Build / build-custom-container-distribution (push) Failing after 7s
Details
Vector IO Integration Tests / test-matrix (3.13, remote::chromadb) (push) Failing after 10s
Details
SqlStore Integration Tests / test-postgres (3.12) (push) Failing after 13s
Details
Unit Tests / unit-tests (3.12) (push) Failing after 6s
Details
Python Package Build Test / build (3.12) (push) Failing after 6s
Details
Vector IO Integration Tests / test-matrix (3.12, inline::faiss) (push) Failing after 11s
Details
Vector IO Integration Tests / test-matrix (3.12, inline::milvus) (push) Failing after 13s
Details
Unit Tests / unit-tests (3.13) (push) Failing after 8s
Details
Vector IO Integration Tests / test-matrix (3.12, inline::sqlite-vec) (push) Failing after 12s
Details
Test Llama Stack Build / generate-matrix (push) Successful in 8s
Details
Python Package Build Test / build (3.13) (push) Failing after 6s
Details
SqlStore Integration Tests / test-postgres (3.13) (push) Failing after 17s
Details
Vector IO Integration Tests / test-matrix (3.12, remote::pgvector) (push) Failing after 11s
Details
Test Llama Stack Build / build-ubi9-container-distribution (push) Failing after 10s
Details
Test External Providers / test-external-providers (venv) (push) Failing after 10s
Details
Vector IO Integration Tests / test-matrix (3.13, inline::sqlite-vec) (push) Failing after 12s
Details
Vector IO Integration Tests / test-matrix (3.13, inline::milvus) (push) Failing after 11s
Details
Vector IO Integration Tests / test-matrix (3.13, remote::pgvector) (push) Failing after 12s
Details
Integration Tests / test-matrix (push) Failing after 12s
Details
Test Llama Stack Build / build (push) Failing after 5s
Details
Vector IO Integration Tests / test-matrix (3.13, inline::faiss) (push) Failing after 25s
Details
Pre-commit / pre-commit (push) Successful in 1m33s
Details

Browse source 
# What does this PR do?

https://github.com/meta-llama/llama-stack/pull/2716/ broke commands
like:

```
 python -m llama_stack.distribution.server.server --config
 llama_stack/templates/starter/run.yaml
 ```

 And will fail with:

 ```
 Traceback (most recent call last):
  File "<frozen runpy>", line 198, in _run_module_as_main
  File "<frozen runpy>", line 88, in _run_code
  File "/Users/leseb/Documents/AI/llama-stack/llama_stack/distribution/server/server.py", line 626, in <module>
    main()
  File "/Users/leseb/Documents/AI/llama-stack/llama_stack/distribution/server/server.py", line 402, in main
    config_file = resolve_config_or_template(args.config, Mode.RUN)
                  ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/Users/leseb/Documents/AI/llama-stack/llama_stack/distribution/utils/config_resolution.py", line 43, in resolve_config_or_template
    config_path = Path(config_or_template)
                  ^^^^^^^^^^^^^^^^^^^^^^^^
  File "/opt/homebrew/Cellar/python@3.12/3.12.8/Frameworks/Python.framework/Versions/3.12/lib/python3.12/pathlib.py", line 1162, in __init__
    super().__init__(*args)
  File "/opt/homebrew/Cellar/python@3.12/3.12.8/Frameworks/Python.framework/Versions/3.12/lib/python3.12/pathlib.py", line 373, in __init__
    raise TypeError(
TypeError: argument should be a str or an os.PathLike object where __fspath__ returns a str, not 'NoneType'
```

Complaining that no positional arguments are present. We now honour the
deprecation until --config and --template are removed completely.

## Test Plan
<!-- Describe the tests you ran to verify your changes with result
summaries. *Provide clear instructions so the plan can be easily
re-executed.* -->

Both ` python -m llama_stack.distribution.server.server --config
llama_stack/templates/starter/run.yaml` and ` python -m
llama_stack.distribution.server.server
llama_stack/templates/starter/run.yaml` should run the server. Same for
`--template starter`.

Signed-off-by: Sébastien Han <seb@redhat.com>
This commit is contained in:
Sébastien Han 2025-07-23 05:48:23 +02:00 • committed by GitHub
parent 340448e0aa
commit c0563c0560
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
2 changed files with 22 additions and 4 deletions
Download patch file Download diff file Expand all files Collapse all files

5
llama_stack/distribution/server/server.py
View file

@ -32,7 +32,7 @@ from openai import BadRequestError
from pydantic import BaseModel, ValidationError
from llama_stack.apis.common.responses import PaginatedResponse
from llama_stack.cli.utils import add_config_template_args
from llama_stack.cli.utils import add_config_template_args, get_config_from_args
from llama_stack.distribution.access_control.access_control import AccessDeniedError
from llama_stack.distribution.datatypes import (
AuthenticationRequiredError,
@ -399,7 +399,8 @@ def main(args: argparse.Namespace | None = None):
if args is None:
args = parser.parse_args()
config_file = resolve_config_or_template(args.config, Mode.RUN)
config_or_template = get_config_from_args(args)
config_file = resolve_config_or_template(config_or_template, Mode.RUN)
logger_config = None
with open(config_file) as fp: