phoenix-oss/llama-stack-mirror
0
0
Fork 1
mirror of https://github.com/meta-llama/llama-stack.git synced 2025-12-11 19:56:03 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions

fix: validate provider_data silently to avoid error log noise

Browse source 
Speculatively checking all providers means validation failures are expected
when users don't provide keys for a provider. Validate directly instead of
using get_request_provider_data() which logs errors.
This commit is contained in:
Ashwin Bharambe 2025-10-29 11:26:36 -07:00
parent 60086df3b5
commit c0d51c89e6
1 changed files with 8 additions and 4 deletions
Download patch file Download diff file Expand all files Collapse all files

12
src/llama_stack/core/routing_tables/models.py
View file

@ -14,6 +14,7 @@ from llama_stack.core.datatypes import (
RegistryEntrySource, RegistryEntrySource,
) )
from llama_stack.core.request_headers import PROVIDER_DATA_VAR, NeedsRequestProviderData from llama_stack.core.request_headers import PROVIDER_DATA_VAR, NeedsRequestProviderData
from llama_stack.core.utils.dynamic import instantiate_class_type
from llama_stack.log import get_logger from llama_stack.log import get_logger
from .common import CommonRoutingTableImpl, lookup_model from .common import CommonRoutingTableImpl, lookup_model
@ -69,10 +70,13 @@ class ModelsRoutingTable(CommonRoutingTableImpl, Models):
if not spec or not getattr(spec, "provider_data_validator", None): if not spec or not getattr(spec, "provider_data_validator", None):
continue continue
# Try to get validated provider_data for this provider # Validate provider_data silently - we're speculatively checking all providers
# Returns None if validation fails (missing keys) or if no provider_data exists # so validation failures are expected when user didn't provide keys for this provider
validated_data = provider.get_request_provider_data() try:
if validated_data is None: validator = instantiate_class_type(spec.provider_data_validator)
validator(**provider_data)
except Exception:
# User didn't provide credentials for this provider - skip silently
continue continue
# Validation succeeded! User has credentials for this provider # Validation succeeded! User has credentials for this provider