From c8f82cad6aea88be3d2b14ece389c8a40c3ee75e Mon Sep 17 00:00:00 2001 From: Roy Belio Date: Thu, 30 Oct 2025 18:52:31 +0200 Subject: [PATCH] fix: detect docker/server mode in telemetry tests to properly disable Gunicorn The telemetry fixture was only checking LLAMA_STACK_TEST_STACK_CONFIG_TYPE environment variable, which defaults to 'library_client'. In CI, tests run with --stack-config=docker:ci-tests, which wasn't being detected as server mode. This commit checks the --stack-config argument and treats both 'server:' and 'docker:' prefixes as server mode, ensuring LLAMA_STACK_DISABLE_GUNICORN is set when needed for telemetry span collection. --- tests/integration/telemetry/conftest.py | 13 +++++++++++-- 1 file changed, 11 insertions(+), 2 deletions(-) diff --git a/tests/integration/telemetry/conftest.py b/tests/integration/telemetry/conftest.py index 2e90f3e9e..8cfed5d4e 100644 --- a/tests/integration/telemetry/conftest.py +++ b/tests/integration/telemetry/conftest.py @@ -17,8 +17,17 @@ from tests.integration.telemetry.collectors import InMemoryTelemetryManager, Otl @pytest.fixture(scope="session") -def telemetry_test_collector(): - stack_mode = os.environ.get("LLAMA_STACK_TEST_STACK_CONFIG_TYPE", "library_client") +def telemetry_test_collector(request): + # Determine stack mode from --stack-config argument + stack_config = request.session.config.getoption("--stack-config", default=None) + if not stack_config: + stack_config = os.environ.get("LLAMA_STACK_CONFIG", "") + + # Check if running in server or docker mode (both need server-side telemetry) + if stack_config.startswith("server:") or stack_config.startswith("docker:"): + stack_mode = "server" + else: + stack_mode = os.environ.get("LLAMA_STACK_TEST_STACK_CONFIG_TYPE", "library_client") if stack_mode == "server": try: