phoenix-oss/llama-stack-mirror
0
0
Fork 1
mirror of https://github.com/meta-llama/llama-stack.git synced 2025-12-04 18:13:44 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions

fix: check if distro dirs exist before listing (#4301)

Browse source 
# What does this PR do?

DISTRO_DIR and DISTRIBS_BASE_DIR need to exist for them to be iterated.
our current logic allows us to iterdir without checking if they exist

## Test Plan

rm ~/.llama/distributions

```
llama stack list-deps starter --format uv | sh
Using Python 3.12.11 environment at: venv
Audited 51 packages in 12ms
Using Python 3.12.11 environment at: venv
Audited 3 packages in 2ms
Using Python 3.12.11 environment at: venv
Audited 1 package in 3ms
Using Python 3.12.11 environment at: venv
Audited 3 packages in 5ms
```

Signed-off-by: Charlie Doern <cdoern@redhat.com>
This commit is contained in:
Charlie Doern 2025-12-03 17:05:47 -05:00 • committed by GitHub
parent 743683ba26
commit c9b50b7e5b
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
1 changed files with 7 additions and 8 deletions
Download patch file Download diff file Expand all files Collapse all files

15
src/llama_stack/core/utils/config_resolution.py
View file

@ -111,15 +111,14 @@ Did you mean one of these distributions?
def _get_available_distros() -> list[str]: def _get_available_distros() -> list[str]:
"""Get list of available distro names.""" """Get list of available distro names."""
if not DISTRO_DIR.exists() and not DISTRIBS_BASE_DIR.exists():
return []
return list( distros = []
set( if DISTRO_DIR.exists():
[d.name for d in DISTRO_DIR.iterdir() if d.is_dir() and not d.name.startswith(".")] distros.extend([d.name for d in DISTRO_DIR.iterdir() if d.is_dir() and not d.name.startswith(".")])
+ [d.name for d in DISTRIBS_BASE_DIR.iterdir() if d.is_dir() and not d.name.startswith(".")] if DISTRIBS_BASE_DIR.exists():
) distros.extend([d.name for d in DISTRIBS_BASE_DIR.iterdir() if d.is_dir() and not d.name.startswith(".")])
)
return list(set(distros))
def _format_distro_suggestions(distros: list[str], user_input: str) -> str: def _format_distro_suggestions(distros: list[str], user_input: str) -> str: