From ccaa9208f77926a3b562c13368b817277b733d1c Mon Sep 17 00:00:00 2001
From: Eric Huang <erichuang@meta.com>
Date: Thu, 2 Oct 2025 11:01:57 -0700
Subject: [PATCH] chore: fix/add logging categories

# What does this PR do?


## Test Plan
---
 llama_stack/log.py                                 | 14 ++++++++++++--
 .../meta_reference/responses/openai_responses.py   |  2 +-
 .../providers/utils/inference/inference_store.py   |  2 +-
 .../providers/utils/responses/responses_store.py   |  2 +-
 4 files changed, 15 insertions(+), 5 deletions(-)

diff --git a/llama_stack/log.py b/llama_stack/log.py
index 2a11516fa..729b2b8c5 100644
--- a/llama_stack/log.py
+++ b/llama_stack/log.py
@@ -31,7 +31,14 @@ CATEGORIES = [
     "client",
     "telemetry",
     "openai_responses",
+    "testing",
+    "providers",
+    "models",
+    "files",
+    "vector_io",
+    "tool_runtime",
 ]
+UNCATEGORIZED = "uncategorized"
 
 # Initialize category levels with default level
 _category_levels: dict[str, int] = dict.fromkeys(CATEGORIES, DEFAULT_LOG_LEVEL)
@@ -165,7 +172,7 @@ def setup_logging(category_levels: dict[str, int], log_file: str | None) -> None
 
         def filter(self, record):
             if not hasattr(record, "category"):
-                record.category = "uncategorized"  # Default to 'uncategorized' if no category found
+                record.category = UNCATEGORIZED  # Default to 'uncategorized' if no category found
             return True
 
     # Determine the root logger's level (default to WARNING if not specified)
@@ -255,7 +262,10 @@ def get_logger(
             log_level = _category_levels[root_category]
         else:
             log_level = _category_levels.get("root", DEFAULT_LOG_LEVEL)
-            logging.warning(f"Unknown logging category: {category}. Falling back to default 'root' level: {log_level}")
+            if category != UNCATEGORIZED:
+                logging.warning(
+                    f"Unknown logging category: {category}. Falling back to default 'root' level: {log_level}"
+                )
     logger.setLevel(log_level)
     return logging.LoggerAdapter(logger, {"category": category})
 
diff --git a/llama_stack/providers/inline/agents/meta_reference/responses/openai_responses.py b/llama_stack/providers/inline/agents/meta_reference/responses/openai_responses.py
index c27dc8467..1a6d75710 100644
--- a/llama_stack/providers/inline/agents/meta_reference/responses/openai_responses.py
+++ b/llama_stack/providers/inline/agents/meta_reference/responses/openai_responses.py
@@ -41,7 +41,7 @@ from .utils import (
     convert_response_text_to_chat_response_format,
 )
 
-logger = get_logger(name=__name__, category="openai::responses")
+logger = get_logger(name=__name__, category="openai_responses")
 
 
 class OpenAIResponsePreviousResponseWithInputItems(BaseModel):
diff --git a/llama_stack/providers/utils/inference/inference_store.py b/llama_stack/providers/utils/inference/inference_store.py
index ffc9f3e11..901f77c67 100644
--- a/llama_stack/providers/utils/inference/inference_store.py
+++ b/llama_stack/providers/utils/inference/inference_store.py
@@ -22,7 +22,7 @@ from ..sqlstore.api import ColumnDefinition, ColumnType
 from ..sqlstore.authorized_sqlstore import AuthorizedSqlStore
 from ..sqlstore.sqlstore import SqlStoreConfig, SqlStoreType, sqlstore_impl
 
-logger = get_logger(name=__name__, category="inference_store")
+logger = get_logger(name=__name__, category="inference")
 
 
 class InferenceStore:
diff --git a/llama_stack/providers/utils/responses/responses_store.py b/llama_stack/providers/utils/responses/responses_store.py
index b9fceb1ab..cb665b88e 100644
--- a/llama_stack/providers/utils/responses/responses_store.py
+++ b/llama_stack/providers/utils/responses/responses_store.py
@@ -25,7 +25,7 @@ from ..sqlstore.api import ColumnDefinition, ColumnType
 from ..sqlstore.authorized_sqlstore import AuthorizedSqlStore
 from ..sqlstore.sqlstore import SqliteSqlStoreConfig, SqlStoreConfig, SqlStoreType, sqlstore_impl
 
-logger = get_logger(name=__name__, category="responses_store")
+logger = get_logger(name=__name__, category="openai_responses")
 
 
 class ResponsesStore: