fix(ci): more correct concurrency key for workflows (#2973)

See comment inline. We don't want a random label to pre-empt an existing
workflow which had gone ahead.
This commit is contained in:
Ashwin Bharambe 2025-07-30 18:23:14 -07:00 committed by GitHub
parent 406ca72957
commit d6ae2b0f47
No known key found for this signature in database
GPG key ID: B5690EEEBB952194

View file

@ -33,7 +33,19 @@ on:
default: 'ollama' default: 'ollama'
concurrency: concurrency:
group: ${{ github.workflow }}-${{ github.ref }}-${{ contains(github.event.pull_request.labels.*.name, 're-record-tests') && 'rerecord' || 'replay' }} # This creates three concurrency groups:
# ${{ github.workflow }}-${{ github.ref }}-rerecord (for valid triggers with re-record-tests label)
# ${{ github.workflow }}-${{ github.ref }}-replay (for valid triggers without re-record-tests label)
# ${{ github.workflow }}-${{ github.ref }}-no-run (for invalid triggers that will be skipped)
# The "no-run" group ensures that irrelevant label events don't interfere with the real workflows.
group: >-
${{ github.workflow }}-${{ github.ref }}-${{
(github.event.action == 'opened' ||
github.event.action == 'synchronize' ||
(github.event.action == 'labeled' && contains(github.event.pull_request.labels.*.name, 're-record-tests'))) &&
(contains(github.event.pull_request.labels.*.name, 're-record-tests') && 'rerecord' || 'replay') ||
'no-run'
}}
cancel-in-progress: true cancel-in-progress: true
jobs: jobs:
@ -110,7 +122,7 @@ jobs:
uses: ./.github/actions/run-integration-tests uses: ./.github/actions/run-integration-tests
with: with:
test-types: ${{ needs.discover-tests.outputs.test-types }} test-types: ${{ needs.discover-tests.outputs.test-types }}
stack-config: 'ci-tests' stack-config: 'server:ci-tests' # recording must be done with server since more tests are run
provider: ${{ inputs.test-provider }} provider: ${{ inputs.test-provider }}
inference-mode: 'record' inference-mode: 'record'