From da53dc3f5fef7b214a80d1d450b62118532f263f Mon Sep 17 00:00:00 2001
From: Xi Yan <xiyan@meta.com>
Date: Thu, 13 Feb 2025 17:10:45 -0800
Subject: [PATCH] fix: openapi for eval-task (#1085)

# What does this PR do?
- as title

## Test Plan
- the deprecated endpoint need to obey what it was before

[//]: # (## Documentation)
---
 docs/_static/llama-stack-spec.html        | 4 ++--
 docs/_static/llama-stack-spec.yaml        | 4 ++--
 llama_stack/apis/benchmarks/benchmarks.py | 2 +-
 3 files changed, 5 insertions(+), 5 deletions(-)

diff --git a/docs/_static/llama-stack-spec.html b/docs/_static/llama-stack-spec.html
index b93f6a380..026a061c8 100644
--- a/docs/_static/llama-stack-spec.html
+++ b/docs/_static/llama-stack-spec.html
@@ -81,7 +81,7 @@
                 "deprecated": true
             }
         },
-        "/v1/eval-tasks/{task_id}": {
+        "/v1/eval-tasks/{eval_task_id}": {
             "get": {
                 "responses": {
                     "200": {
@@ -109,7 +109,7 @@
                 "parameters": [
                     {
                         "name": "eval_task_id",
-                        "in": "query",
+                        "in": "path",
                         "required": true,
                         "schema": {
                             "type": "string"
diff --git a/docs/_static/llama-stack-spec.yaml b/docs/_static/llama-stack-spec.yaml
index b30025020..e4f0398c0 100644
--- a/docs/_static/llama-stack-spec.yaml
+++ b/docs/_static/llama-stack-spec.yaml
@@ -35,7 +35,7 @@ paths:
               $ref: '#/components/schemas/DeprecatedEvaluateRowsRequest'
         required: true
       deprecated: true
-  /v1/eval-tasks/{task_id}:
+  /v1/eval-tasks/{eval_task_id}:
     get:
       responses:
         '200':
@@ -51,7 +51,7 @@ paths:
       description: ''
       parameters:
         - name: eval_task_id
-          in: query
+          in: path
           required: true
           schema:
             type: string
diff --git a/llama_stack/apis/benchmarks/benchmarks.py b/llama_stack/apis/benchmarks/benchmarks.py
index 50019b18c..af5784bbc 100644
--- a/llama_stack/apis/benchmarks/benchmarks.py
+++ b/llama_stack/apis/benchmarks/benchmarks.py
@@ -68,7 +68,7 @@ class Benchmarks(Protocol):
     @webmethod(route="/eval-tasks", method="GET")
     async def DEPRECATED_list_eval_tasks(self) -> ListBenchmarksResponse: ...
 
-    @webmethod(route="/eval-tasks/{task_id}", method="GET")
+    @webmethod(route="/eval-tasks/{eval_task_id}", method="GET")
     async def DEPRECATED_get_eval_task(
         self,
         eval_task_id: str,