phoenix-oss/llama-stack-mirror
0
0
Fork 1
mirror of https://github.com/meta-llama/llama-stack.git synced 2025-12-11 19:56:03 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions

fix: handle missing type_checking group on release-0.3.x

Browse source 
The release branch doesn't have the type_checking dependency group yet.
Check if it exists and fall back to dev-only if not found.
This commit is contained in:
Ashwin Bharambe 2025-10-31 07:07:06 -07:00
parent 8046588f29
commit dea3f8f5b0
1 changed files with 15 additions and 4 deletions
Download patch file Download diff file Expand all files Collapse all files

19
.github/workflows/pre-commit.yml vendored
View file

@ -137,13 +137,22 @@ jobs:
id: client-config id: client-config
uses: ./.github/actions/install-llama-stack-client uses: ./.github/actions/install-llama-stack-client
- name: Sync dev + type_checking dependencies - name: Sync dev dependencies for mypy
env: env:
UV_INDEX_URL: ${{ steps.client-config.outputs.uv-index-url }} UV_INDEX_URL: ${{ steps.client-config.outputs.uv-index-url }}
UV_EXTRA_INDEX_URL: ${{ steps.client-config.outputs.uv-extra-index-url }} UV_EXTRA_INDEX_URL: ${{ steps.client-config.outputs.uv-extra-index-url }}
UV_INDEX_STRATEGY: ${{ steps.client-config.outputs.uv-index-url && 'unsafe-best-match' || '' }} UV_INDEX_STRATEGY: ${{ steps.client-config.outputs.uv-index-url && 'unsafe-best-match' || '' }}
run: | run: |
uv sync --group dev --group type_checking # Check if type_checking group exists, otherwise just use dev
if grep -q "type.checking" pyproject.toml; then
echo "Found type_checking group, syncing with both groups"
uv sync --group dev --group type_checking
MYPY_CMD="uv run --group dev --group type_checking mypy"
else
echo "No type_checking group found, syncing with dev only"
uv sync --group dev
MYPY_CMD="uv run --group dev mypy"
fi
# Install specific client version after sync if needed # Install specific client version after sync if needed
if [ "${{ steps.client-config.outputs.install-after-sync }}" = "true" ]; then if [ "${{ steps.client-config.outputs.install-after-sync }}" = "true" ]; then
@ -151,10 +160,12 @@ jobs:
uv pip install ${{ steps.client-config.outputs.install-source }} uv pip install ${{ steps.client-config.outputs.install-source }}
fi fi
- name: Run mypy (full type_checking) echo "MYPY_CMD=$MYPY_CMD" >> $GITHUB_ENV
- name: Run mypy (full type checking)
run: | run: |
set +e set +e
uv run --group dev --group type_checking mypy $MYPY_CMD
status=$? status=$?
if [ $status -ne 0 ]; then if [ $status -ne 0 ]; then
echo "::error::Full mypy failed. Reproduce locally with 'uv run pre-commit run mypy-full --hook-stage manual --all-files'." echo "::error::Full mypy failed. Reproduce locally with 'uv run pre-commit run mypy-full --hook-stage manual --all-files'."