From e7444c1d9b3001f3fccbf39de59a8569a3c52388 Mon Sep 17 00:00:00 2001 From: Mustafa Elbehery Date: Mon, 8 Sep 2025 18:28:19 +0200 Subject: [PATCH] chore: remove irrelevant comments Signed-off-by: Mustafa Elbehery --- tests/unit/providers/vector_io/conftest.py | 2 +- tests/unit/providers/vector_io/remote/test_milvus.py | 5 +---- 2 files changed, 2 insertions(+), 5 deletions(-) diff --git a/tests/unit/providers/vector_io/conftest.py b/tests/unit/providers/vector_io/conftest.py index b8ea7a203..34a1f5d1d 100644 --- a/tests/unit/providers/vector_io/conftest.py +++ b/tests/unit/providers/vector_io/conftest.py @@ -182,7 +182,7 @@ async def milvus_vec_index(milvus_vec_db_path, embedding_dimension): index = MilvusIndex(client, name, consistency_level="Strong") index.db_path = milvus_vec_db_path yield index - # Proper cleanup: close the async client + await client.close() diff --git a/tests/unit/providers/vector_io/remote/test_milvus.py b/tests/unit/providers/vector_io/remote/test_milvus.py index 6e8817366..04bac71c2 100644 --- a/tests/unit/providers/vector_io/remote/test_milvus.py +++ b/tests/unit/providers/vector_io/remote/test_milvus.py @@ -48,7 +48,7 @@ async def mock_milvus_client() -> MagicMock: # Mock async insert operation client.insert = AsyncMock(return_value={"insert_count": 10}) - # Mock async search operation - return mock results (data should be dict, not JSON string) + # Mock async search operation client.search = AsyncMock( return_value=[ [ @@ -87,13 +87,10 @@ async def mock_milvus_client() -> MagicMock: ] ) - # Mock async hybrid_search operation client.hybrid_search = AsyncMock(return_value=[]) - # Mock async delete operation client.delete = AsyncMock(return_value=None) - # Mock async close operation client.close = AsyncMock(return_value=None) return client