phoenix-oss/llama-stack-mirror
0
0
Fork 1
mirror of https://github.com/meta-llama/llama-stack.git synced 2025-10-15 22:47:59 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions

feat(tools)!: substantial clean up of "Tool" related datatypes (#3627)

Browse source 
This is a sweeping change to clean up some gunk around our "Tool"
definitions.

First, we had two types `Tool` and `ToolDef`. The first of these was a
"Resource" type for the registry but we had stopped registering tools
inside the Registry long back (and only registered ToolGroups.) The
latter was for specifying tools for the Agents API. This PR removes the
former and adds an optional `toolgroup_id` field to the latter.

Secondly, as pointed out by @bbrowning in
https://github.com/llamastack/llama-stack/pull/3003#issuecomment-3245270132,
we were doing a lossy conversion from a full JSON schema from the MCP
tool specification into our ToolDefinition to send it to the model.
There is no necessity to do this -- we ourselves aren't doing any
execution at all but merely passing it to the chat completions API which
supports this. By doing this (and by doing it poorly), we encountered
limitations like not supporting array items, or not resolving $refs,
etc.

To fix this, we replaced the `parameters` field by `{ input_schema,
output_schema }` which can be full blown JSON schemas.

Finally, there were some types in our llama-related chat format
conversion which needed some cleanup. We are taking this opportunity to
clean those up.

This PR is a substantial breaking change to the API. However, given our
window for introducing breaking changes, this suits us just fine. I will
be landing a concurrent `llama-stack-client` change as well since API
shapes are changing.
This commit is contained in:
Ashwin Bharambe 2025-10-02 15:12:03 -07:00 • committed by GitHub
parent 1f5003d50e
commit ef0736527d
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
179 changed files with 34186 additions and 9171 deletions
Download patch file Download diff file Expand all files Collapse all files

768
tests/integration/recordings/responses/c13d7510774c.json
View file

@ -18,390 +18,390 @@
"data": [
{
"embedding": [
-0.0011296043,
0.06740522,
0.015186453,
0.037259158,
0.02935556,
0.015181291,
0.07432997,
-0.0033194474,
0.0658106,
-0.021833794,
0.034404922,
0.05099269,
-0.011411872,
-0.025082853,
-0.051754408,
0.027195254,
0.07849019,
-0.06000248,
0.010478361,
-0.003392346,
0.043441977,
0.12292443,
9.388175e-05,
0.0021187037,
0.018079525,
0.045084555,
-0.097606525,
0.11185215,
0.049650617,
-0.0348426,
-0.039580915,
0.0035499185,
0.15893514,
0.063421525,
0.047970187,
0.011613767,
0.009793674,
0.01536712,
0.009413064,
0.07999014,
0.01915802,
-0.13722447,
0.017290922,
0.013689777,
0.014259784,
-0.00021621982,
-0.017730612,
0.022902183,
0.035927463,
-0.015361024,
-0.00975885,
-0.040180918,
-0.011500755,
0.00012558368,
0.08540788,
0.08731169,
0.004690206,
0.006160604,
0.003023499,
0.008887178,
-0.006278653,
0.050593477,
0.00053471717,
0.04677382,
0.09365536,
-0.012813678,
0.0177166,
-0.06271032,
-0.11535796,
0.04110661,
-0.014942371,
0.044813167,
-0.020877626,
0.04299617,
-0.06107898,
0.01997848,
-0.0687263,
-0.035494387,
0.04186985,
0.012177578,
-0.029081868,
-0.066437304,
0.030620316,
0.05150629,
-0.12813967,
0.06819209,
-0.047090717,
-0.032926783,
0.007485966,
-0.017814271,
0.038294822,
-0.015788501,
0.07054281,
0.03807343,
-0.114283286,
0.042118594,
-0.111601785,
-0.04573834,
-0.02895515,
0.12735783,
-0.013941619,
-0.027150463,
0.072897464,
0.024098374,
-0.054044593,
-0.13128933,
0.030136578,
-0.023237763,
-0.019079136,
-0.0078745885,
-0.021944366,
-0.053324133,
-0.070892006,
-0.011552823,
-0.023377078,
-0.01562657,
0.051452935,
0.029251281,
0.06480842,
0.06403676,
0.014424153,
-0.057994097,
-0.06993807,
-0.023921017,
-0.08493092,
-0.087801315,
0.048142783,
-6.124397e-33,
0.0103092175,
0.038688924,
0.003180582,
0.03575604,
0.005059993,
-0.0041896994,
-0.05389261,
-0.029881287,
-0.075520456,
-0.07879111,
-0.012291425,
-0.05053033,
0.020719253,
-0.05190443,
-0.05927485,
-0.05987536,
-0.05572788,
0.03220933,
-0.006331632,
-0.021651596,
-0.059913907,
0.051977657,
0.05122985,
-0.06350782,
-0.04872765,
-0.014282773,
0.0025304393,
-0.024342295,
-0.0055265254,
0.020074077,
-0.10194665,
0.010741537,
-0.02318619,
-0.08105595,
-0.014973416,
0.0017918752,
0.045083463,
-0.05282281,
-0.053680934,
-0.013229242,
-0.019794637,
0.020036008,
-0.00081875344,
-0.10115686,
-0.0006884125,
0.09664284,
-0.03943104,
0.04955554,
0.042241447,
0.007962193,
-0.052323878,
0.05189162,
0.037112337,
0.034818016,
0.063431285,
-0.02657652,
-0.009212341,
-0.0025556423,
-0.05609933,
0.0020433308,
-0.020113751,
0.0012227942,
-0.0017669081,
0.019119242,
0.016553605,
-0.011386767,
0.010368127,
-0.00788346,
0.046651863,
-0.046871297,
-0.085224025,
-0.008958986,
0.012052177,
0.013311017,
0.015157192,
0.03708167,
0.026588887,
0.014486772,
-0.013955214,
0.019986698,
-0.06885552,
-0.07106239,
0.012334861,
0.03284816,
-0.03151976,
0.045773514,
0.067994975,
-0.077492714,
0.018440822,
0.06622958,
-0.08641996,
0.008967366,
0.04134085,
0.009518882,
0.006565088,
4.711897e-33,
-0.02617601,
0.0013207985,
-0.014141556,
-0.024331013,
0.06929469,
0.03143924,
0.03726272,
0.064707026,
0.049426436,
0.11073603,
0.0498569,
0.066796474,
0.04154851,
-0.034098588,
0.07028382,
0.034863915,
0.12904617,
-0.021078404,
0.008925486,
0.03016334,
-0.02286831,
0.03649071,
-0.13193603,
0.045608096,
-0.012805477,
0.041747537,
0.12321406,
-0.013507891,
-0.007307474,
-0.02975696,
0.025006123,
-0.009506256,
0.024761083,
0.023204166,
-0.019123148,
0.02259915,
0.013744109,
-0.03847919,
-0.014476444,
0.07522499,
0.13586833,
0.009872778,
-0.03752485,
-0.0273059,
-0.016470777,
-0.048831154,
-0.03521732,
-0.054363117,
-0.0017890002,
0.035665076,
-0.010268516,
-0.018602924,
-0.036469962,
-0.055976517,
-0.007821111,
0.00907826,
-0.0073335953,
0.050373644,
-0.00025981313,
-0.036349144,
-0.024950698,
0.058883175,
-0.07245624,
0.07399545,
0.053919416,
-0.051881794,
-0.0063462397,
0.07852022,
-0.016959544,
-0.0066832895,
0.01265072,
-0.014152041,
-0.13643119,
-0.085250236,
-0.017519519,
-0.00466121,
0.0136799645,
0.0009118405,
-0.071966685,
-0.06886893,
0.14207116,
0.03186518,
-0.05592076,
0.030404905,
0.061872244,
0.029894035,
-0.00096155383,
-0.06500391,
-0.020616096,
0.039591115,
-0.12383165,
0.0028830946,
0.051231142,
0.13391772,
-0.08845233,
-1.7589368e-08,
-0.025769057,
-0.080324695,
-0.09164953,
0.032005485,
0.005889216,
0.114638664,
0.0233727,
-0.069048144,
-0.05594302,
-0.05788277,
0.014665582,
0.080326974,
0.0036707798,
-0.030798541,
0.024442635,
0.008542568,
-0.05288123,
-0.06640491,
0.00074039627,
-0.023801958,
0.030778948,
0.054075025,
-0.0027453878,
-0.09929041,
-0.0150463935,
0.01624328,
-0.0015419688,
0.011909824,
0.007890519,
0.0489657,
0.004866092,
0.08265809,
-0.0145542445,
-0.04386104,
0.004611713,
0.024626419,
0.023854014,
0.0236921,
0.05076065,
-0.051832993,
0.021252805,
-0.0033932943,
-0.021158189,
0.020595197,
-0.06475187,
0.054174356,
0.027812954,
-0.05294382,
0.015094968,
-0.119794324,
-0.034157146,
-0.012219483,
0.047453884,
0.020896995,
-0.026357891,
0.015037571,
0.033969007,
0.05981613,
-0.052542053,
0.033553857,
0.06119396,
0.09635468,
0.11632743,
-0.016134953
-0.0010839553,
0.067364,
0.015185306,
0.037240896,
0.029337138,
0.015160007,
0.0743005,
-0.0032980628,
0.06581814,
-0.021851996,
0.034412965,
0.051005766,
-0.011422501,
-0.025062356,
-0.051756065,
0.027193472,
0.07849549,
-0.05999108,
0.010471458,
-0.003400683,
0.043449093,
0.122919865,
9.668583e-05,
0.002153268,
0.018064681,
0.045069378,
-0.09762388,
0.11186886,
0.049657565,
-0.03485217,
-0.039568134,
0.003532146,
0.15894793,
0.06341193,
0.047953114,
0.011617699,
0.009799243,
0.015377702,
0.009379663,
0.079989135,
0.019207356,
-0.13718612,
0.01730099,
0.013687199,
0.014266827,
-0.00022628276,
-0.017710257,
0.02291068,
0.03590651,
-0.015361055,
-0.00978436,
-0.0401825,
-0.011481894,
0.00014050963,
0.08540761,
0.08730027,
0.0046967245,
0.006164595,
0.003031956,
0.008891807,
-0.006260525,
0.05061661,
0.0005252785,
0.0467754,
0.09363822,
-0.012814104,
0.017708639,
-0.062698044,
-0.11535818,
0.041123625,
-0.014939021,
0.044815876,
-0.020868087,
0.042999975,
-0.061038766,
0.019998673,
-0.068740115,
-0.035516046,
0.041884515,
0.012185281,
-0.029084096,
-0.06643917,
0.030638866,
0.05149607,
-0.12815061,
0.06821646,
-0.047070153,
-0.032925386,
0.007499353,
-0.017841771,
0.038296465,
-0.015792726,
0.07054022,
0.038072467,
-0.11428876,
0.04210153,
-0.11162366,
-0.045723915,
-0.028951947,
0.12735675,
-0.013946637,
-0.027157523,
0.07295939,
0.024098422,
-0.054050542,
-0.13125896,
0.03013205,
-0.023223283,
-0.019072957,
-0.007864101,
-0.021954412,
-0.05329901,
-0.07088355,
-0.0115214065,
-0.023399564,
-0.015638318,
0.05148062,
0.029261008,
0.06481798,
0.064031154,
0.014445124,
-0.058017716,
-0.069921836,
-0.023950975,
-0.08490842,
-0.08779567,
0.048162255,
-6.1240354e-33,
0.010315817,
0.038685724,
0.0031864564,
0.0357421,
0.0050265454,
-0.004210234,
-0.053900674,
-0.02988569,
-0.07548199,
-0.078777455,
-0.012271205,
-0.05056629,
0.020729113,
-0.051866043,
-0.059254467,
-0.059903424,
-0.055699438,
0.032196835,
-0.006328442,
-0.021668624,
-0.059921067,
0.0519611,
0.051227964,
-0.063502096,
-0.04873505,
-0.014265467,
0.0025537873,
-0.024346355,
-0.0055181426,
0.02007461,
-0.10196586,
0.010727814,
-0.023194604,
-0.081025146,
-0.014997581,
0.0017926424,
0.045078833,
-0.052792255,
-0.05368693,
-0.013245513,
-0.019808132,
0.020031843,
-0.00081401254,
-0.10117647,
-0.0007066768,
0.09663035,
-0.03946875,
0.04954661,
0.042237334,
0.007943922,
-0.05234212,
0.051887065,
0.03711589,
0.034850314,
0.063441575,
-0.026583876,
-0.009227281,
-0.0025737104,
-0.056082893,
0.0020716325,
-0.020129146,
0.0012315192,
-0.0017609745,
0.019111704,
0.016572498,
-0.011374,
0.010381644,
-0.007864189,
0.04664868,
-0.046856377,
-0.08523834,
-0.008974813,
0.012022968,
0.013285977,
0.015182303,
0.03708482,
0.026587088,
0.014473839,
-0.013946565,
0.01999883,
-0.06888259,
-0.07111367,
0.012369427,
0.032828625,
-0.03152666,
0.045777358,
0.06801705,
-0.07747748,
0.018461134,
0.06620267,
-0.086365156,
0.008950603,
0.041320425,
0.009541193,
0.0066037327,
4.71081e-33,
-0.026172558,
0.0013145636,
-0.014140948,
-0.024360213,
0.06931815,
0.031448748,
0.037257418,
0.06468137,
0.049403396,
0.11072201,
0.04985356,
0.06679111,
0.04153249,
-0.034106053,
0.070283465,
0.034855895,
0.12902643,
-0.021033453,
0.008940618,
0.030177405,
-0.022881329,
0.036504544,
-0.13194299,
0.045612644,
-0.0127895875,
0.04174139,
0.1232064,
-0.013484046,
-0.007285246,
-0.029776007,
0.025007037,
-0.009516822,
0.02475585,
0.023208592,
-0.019141924,
0.02259424,
0.013740329,
-0.038490705,
-0.014461541,
0.075218394,
0.13589163,
0.009839605,
-0.037563317,
-0.02737327,
-0.016485116,
-0.048845276,
-0.03523722,
-0.05439929,
-0.0017957076,
0.03563579,
-0.010255764,
-0.01859244,
-0.03647324,
-0.055985246,
-0.007833892,
0.009086756,
-0.007333394,
0.050386623,
-0.0002305643,
-0.03637248,
-0.024937423,
0.058877032,
-0.07250415,
0.07401245,
0.053917013,
-0.051895224,
-0.006332244,
0.07850189,
-0.01695057,
-0.006673017,
0.012659739,
-0.014127065,
-0.13639799,
-0.08524976,
-0.017533274,
-0.0046930755,
0.013687301,
0.0009185522,
-0.0719948,
-0.06887779,
0.14208324,
0.03187123,
-0.055919908,
0.030401653,
0.061900012,
0.029921472,
-0.00096237566,
-0.065010294,
-0.020657646,
0.039562404,
-0.123846576,
0.0028867351,
0.051196404,
0.13397509,
-0.088453874,
-1.7590333e-08,
-0.025786474,
-0.080303885,
-0.09164947,
0.031999,
0.00584884,
0.11464121,
0.023377793,
-0.06902527,
-0.055941124,
-0.05787791,
0.014640494,
0.080320895,
0.0037027278,
-0.030824674,
0.024432683,
0.008549355,
-0.05291309,
-0.06636625,
0.0007468212,
-0.02379191,
0.030766092,
0.054053318,
-0.0027251292,
-0.09928475,
-0.0150488615,
0.016240431,
-0.0015727071,
0.01190173,
0.007895162,
0.04894733,
0.00487708,
0.08263861,
-0.014527478,
-0.043879665,
0.004633697,
0.024611989,
0.023827499,
0.02366802,
0.050754935,
-0.051841788,
0.0212632,
-0.0034418616,
-0.021175656,
0.020591663,
-0.06475325,
0.0542002,
0.027792262,
-0.05295982,
0.01509645,
-0.11977527,
-0.03416359,
-0.012206606,
0.047451705,
0.020876253,
-0.026368074,
0.01502373,
0.033982284,
0.059788153,
-0.052526973,
0.03356499,
0.061180886,
0.096336305,
0.116353564,
-0.016122948
],
"index": 0,
"object": "embedding"