From 121a8584d6114b5e3ca2898bf2713fe1c432bbaa Mon Sep 17 00:00:00 2001 From: Habeb Nawatha <109216430+HabebNawatha@users.noreply.github.com> Date: Thu, 14 Aug 2025 17:09:59 +0300 Subject: [PATCH] fix: make provider_id a required field in vector DB registration --- llama_stack/apis/vector_dbs/vector_dbs.py | 2 +- llama_stack/core/routing_tables/vector_dbs.py | 11 +---------- 2 files changed, 2 insertions(+), 11 deletions(-) diff --git a/llama_stack/apis/vector_dbs/vector_dbs.py b/llama_stack/apis/vector_dbs/vector_dbs.py index 47820fa0f..47adf2a12 100644 --- a/llama_stack/apis/vector_dbs/vector_dbs.py +++ b/llama_stack/apis/vector_dbs/vector_dbs.py @@ -90,8 +90,8 @@ class VectorDBs(Protocol): self, vector_db_id: str, embedding_model: str, + provider_id: str, embedding_dimension: int | None = 384, - provider_id: str | None = None, vector_db_name: str | None = None, provider_vector_db_id: str | None = None, ) -> VectorDB: diff --git a/llama_stack/core/routing_tables/vector_dbs.py b/llama_stack/core/routing_tables/vector_dbs.py index e8dc46997..00b167cca 100644 --- a/llama_stack/core/routing_tables/vector_dbs.py +++ b/llama_stack/core/routing_tables/vector_dbs.py @@ -47,21 +47,12 @@ class VectorDBsRoutingTable(CommonRoutingTableImpl, VectorDBs): self, vector_db_id: str, embedding_model: str, + provider_id: str, embedding_dimension: int | None = 384, - provider_id: str | None = None, provider_vector_db_id: str | None = None, vector_db_name: str | None = None, ) -> VectorDB: provider_vector_db_id = provider_vector_db_id or vector_db_id - if provider_id is None: - if len(self.impls_by_provider_id) > 0: - provider_id = list(self.impls_by_provider_id.keys())[0] - if len(self.impls_by_provider_id) > 1: - logger.warning( - f"No provider specified and multiple providers available. Arbitrarily selected the first provider {provider_id}." - ) - else: - raise ValueError("No provider available. Please configure a vector_io provider.") model = await lookup_model(self, embedding_model) if model is None: raise ModelNotFoundError(embedding_model)