address feedback

This commit is contained in:
Dinesh Yeduguru 2024-11-08 12:00:36 -08:00
parent 0eaca98229
commit fe072620c8
9 changed files with 16 additions and 33 deletions

View file

@ -26,7 +26,7 @@ class Resource(BaseModel):
description="Unique identifier for this resource in llama stack"
)
provider_resource_identifier: str = Field(
provider_resource_id: str = Field(
description="Unique identifier for this resource in the provider",
default=None,
)

View file

@ -38,7 +38,7 @@ class ShieldsClient(Shields):
self,
shield_id: str,
shield_type: ShieldType,
provider_resource_identifier: Optional[str],
provider_shield_id: Optional[str],
provider_id: Optional[str],
params: Optional[Dict[str, Any]],
) -> None:
@ -48,7 +48,7 @@ class ShieldsClient(Shields):
json={
"shield_id": shield_id,
"shield_type": shield_type,
"provider_resource_identifier": provider_resource_identifier,
"provider_shield_id": provider_shield_id,
"provider_id": provider_id,
"params": params,
},

View file

@ -42,7 +42,7 @@ class Shields(Protocol):
self,
shield_id: str,
shield_type: ShieldType,
provider_resource_identifier: Optional[str] = None,
provider_shield_id: Optional[str] = None,
provider_id: Optional[str] = None,
params: Optional[Dict[str, Any]] = None,
) -> Shield: ...