4 commits

Author	SHA1	Message	Date
Ashwin Bharambe	dbd036e7b4	Address PR review feedback ... - Simplify provider_resource_id assignment with assertion (review comment 1) - Fix comment placement order (review comment 2) - Refactor tool_calls list building to avoid union-attr suppression (review comment 3) - Rename response_format to response_format_dict to avoid shadowing (review comment 4) - Update type: ignore comments for message.content with accurate explanation of OpenAI SDK type alias resolution issue (review comment 5) - Add assertions in litellm_openai_mixin to validate provider_resource_id is not None 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>	2025-10-28 13:49:34 -07:00
Ashwin Bharambe	9032ba9097	add comments explaining the suppressions	2025-10-28 13:32:21 -07:00
Ashwin Bharambe	a8d51a1a8b	fix(mypy): resolve OpenAI compatibility layer type issues ... Resolves 111 mypy errors across OpenAI inference compatibility utilities: litellm_openai_mixin.py (23 errors → 1 unavoidable): - Add type annotation for input_dict parameter - Fix JsonSchemaResponseFormat dict conversion and manipulation - Add None checks for tool_config access with walrus operator - Fix get_api_key() to properly handle None key_field - Add model_store None checks in all three OpenAI methods - Add type annotations for provider_resource_id variable - Add type: ignore for litellm external library returns openai_compat.py (88 errors → 0): - Add None checks for TopPSamplingStrategy temperature and top_p - Add type: ignore for no-any-return in text_from_choice - Fix union-attr errors in logprobs iteration with None checks - Add None checks for choice.text and finish_reason - Fix OpenAICompatCompletionChoice.message attribute access - Filter tool_calls to only valid ToolCall objects - Add type annotations for converted_messages and choices lists - Fix TypedDict ** expansion issues in message conversions - Add type: ignore for function dict index operations - Fix tool_choice and response_format type conversions - Add type annotations for lls_tools variable - Fix sampling strategy assignment with proper ordering - Add None checks for buffer string concatenations - Rename shadowed tool_call variable to parsed_tool_call - Fix message content and tool_calls type conversions - Add isinstance checks before attribute access on content - Fix OpenAI finish_reason type literal conversions Code remains clean and readable with strategic use of type: ignore pragmas only where necessary for external library compatibility. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>	2025-10-28 13:12:43 -07:00
Ashwin Bharambe	471b1b248b	chore(package): migrate to src/ layout (#3920) ... Migrates package structure to src/ layout following Python packaging best practices. All code moved from `llama_stack/` to `src/llama_stack/`. Public API unchanged - imports remain `import llama_stack.*`. Updated build configs, pre-commit hooks, scripts, and GitHub workflows accordingly. All hooks pass, package builds cleanly. **Developer note**: Reinstall after pulling: `pip install -e .`	2025-10-27 12:02:21 -07:00

Renamed from llama_stack/providers/utils/inference/openai_compat.py (Browse further)