mirror of
https://github.com/meta-llama/llama-stack.git
synced 2025-10-15 14:43:48 +00:00
007efa6eb5
# What does this PR do? <!-- Provide a short summary of what this PR does and why. Link to relevant issues if applicable. --> The purpose of this PR is to replace the Llama Stack's default embedding model by nomic-embed-text-v1.5. These are the key reasons why Llama Stack community decided to switch from all-MiniLM-L6-v2 to nomic-embed-text-v1.5: 1. The training data for [all-MiniLM-L6-v2](https://huggingface.co/sentence-transformers/all-MiniLM-L6-v2#training-data) includes a lot of data sets with various licensing terms, so it is tricky to know when/whether it is appropriate to use this model for commercial applications. 2. The model is not particularly competitive on major benchmarks. For example, if you look at the [MTEB Leaderboard](https://huggingface.co/spaces/mteb/leaderboard) and click on Miscellaneous/BEIR to see English information retrieval accuracy, you see that the top of the leaderboard is dominated by enormous models but also that there are many, many models of relatively modest size whith much higher Retrieval scores. If you want to look closely at the data, I recommend clicking "Download Table" because it is easier to browse that way. More discussion info can be founded [here](https://github.com/llamastack/llama-stack/issues/2418) <!-- If resolving an issue, uncomment and update the line below --> <!-- Closes #[issue-number] --> Closes #2418 ## Test Plan <!-- Describe the tests you ran to verify your changes with result summaries. *Provide clear instructions so the plan can be easily re-executed.* --> 1. Run `./scripts/unit-tests.sh` 2. Integration tests via CI wokrflow --------- Signed-off-by: Sébastien Han <seb@redhat.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: Francisco Arceo <arceofrancisco@gmail.com> Co-authored-by: Sébastien Han <seb@redhat.com> |
||
|---|---|---|
| .. | ||
| changelog.yml | ||
| conformance.yml | ||
| install-script-ci.yml | ||
| integration-auth-tests.yml | ||
| integration-sql-store-tests.yml | ||
| integration-tests.yml | ||
| integration-vector-io-tests.yml | ||
| pre-commit.yml | ||
| precommit-trigger.yml | ||
| providers-build.yml | ||
| python-build-test.yml | ||
| README.md | ||
| record-integration-tests.yml | ||
| semantic-pr.yml | ||
| stale_bot.yml | ||
| test-external-provider-module.yml | ||
| test-external.yml | ||
| ui-unit-tests.yml | ||
| unit-tests.yml | ||
Llama Stack CI
Llama Stack uses GitHub Actions for Continuous Integration (CI). Below is a table detailing what CI the project includes and the purpose.
| Name | File | Purpose |
|---|---|---|
| Update Changelog | changelog.yml | Creates PR for updating the CHANGELOG.md |
| API Conformance Tests | conformance.yml | Run the API Conformance test suite on the changes. |
| Installer CI | install-script-ci.yml | Test the installation script |
| Integration Auth Tests | integration-auth-tests.yml | Run the integration test suite with Kubernetes authentication |
| SqlStore Integration Tests | integration-sql-store-tests.yml | Run the integration test suite with SqlStore |
| Integration Tests (Replay) | integration-tests.yml | Run the integration test suites from tests/integration in replay mode |
| Vector IO Integration Tests | integration-vector-io-tests.yml | Run the integration test suite with various VectorIO providers |
| Pre-commit | pre-commit.yml | Run pre-commit checks |
| Pre-commit Bot | precommit-trigger.yml | Pre-commit bot for PR |
| Test Llama Stack Build | providers-build.yml | Test llama stack build |
| Python Package Build Test | python-build-test.yml | Test building the llama-stack PyPI project |
| Integration Tests (Record) | record-integration-tests.yml | Run the integration test suite from tests/integration |
| Check semantic PR titles | semantic-pr.yml | Ensure that PR titles follow the conventional commit spec |
| Close stale issues and PRs | stale_bot.yml | Run the Stale Bot action |
| Test External Providers Installed via Module | test-external-provider-module.yml | Test External Provider installation via Python module |
| Test External API and Providers | test-external.yml | Test the External API and Provider mechanisms |
| UI Tests | ui-unit-tests.yml | Run the UI test suite |
| Unit Tests | unit-tests.yml | Run the unit test suite |