mirror of
https://github.com/meta-llama/llama-stack.git
synced 2025-07-06 14:00:42 +00:00
25268854bc
# What does this PR do?
We were not using conditionals correctly, conditionals can only be used
when the env variable is set, so `${env.ENVIRONMENT:+}` would return
None is ENVIRONMENT is not set.
If you want to create a conditional value, you need to do
`${env.ENVIRONMENT:=}`, this will pick the value of ENVIRONMENT if set,
otherwise will return None.
Closes: https://github.com/meta-llama/llama-stack/issues/2564
Signed-off-by: Sébastien Han <seb@redhat.com>
77 lines
2.8 KiB
Python
77 lines
2.8 KiB
Python
# Copyright (c) Meta Platforms, Inc. and affiliates.
|
|
# All rights reserved.
|
|
#
|
|
# This source code is licensed under the terms described in the LICENSE file in
|
|
# the root directory of this source tree.
|
|
|
|
import os
|
|
import unittest
|
|
|
|
from llama_stack.distribution.stack import replace_env_vars
|
|
|
|
|
|
class TestReplaceEnvVars(unittest.TestCase):
|
|
def setUp(self):
|
|
# Clear any existing environment variables we'll use in tests
|
|
for var in ["TEST_VAR", "EMPTY_VAR", "ZERO_VAR"]:
|
|
if var in os.environ:
|
|
del os.environ[var]
|
|
|
|
# Set up test environment variables
|
|
os.environ["TEST_VAR"] = "test_value"
|
|
os.environ["EMPTY_VAR"] = ""
|
|
os.environ["ZERO_VAR"] = "0"
|
|
|
|
def test_simple_replacement(self):
|
|
self.assertEqual(replace_env_vars("${env.TEST_VAR}"), "test_value")
|
|
|
|
def test_default_value_when_not_set(self):
|
|
self.assertEqual(replace_env_vars("${env.NOT_SET:=default}"), "default")
|
|
|
|
def test_default_value_when_set(self):
|
|
self.assertEqual(replace_env_vars("${env.TEST_VAR:=default}"), "test_value")
|
|
|
|
def test_default_value_when_empty(self):
|
|
self.assertEqual(replace_env_vars("${env.EMPTY_VAR:=default}"), "default")
|
|
|
|
def test_none_value_when_empty(self):
|
|
self.assertEqual(replace_env_vars("${env.EMPTY_VAR:=}"), None)
|
|
|
|
def test_value_when_set(self):
|
|
self.assertEqual(replace_env_vars("${env.TEST_VAR:=}"), "test_value")
|
|
|
|
def test_empty_var_no_default(self):
|
|
self.assertEqual(replace_env_vars("${env.EMPTY_VAR_NO_DEFAULT:+}"), None)
|
|
|
|
def test_conditional_value_when_set(self):
|
|
self.assertEqual(replace_env_vars("${env.TEST_VAR:+conditional}"), "conditional")
|
|
|
|
def test_conditional_value_when_not_set(self):
|
|
self.assertEqual(replace_env_vars("${env.NOT_SET:+conditional}"), None)
|
|
|
|
def test_conditional_value_when_empty(self):
|
|
self.assertEqual(replace_env_vars("${env.EMPTY_VAR:+conditional}"), None)
|
|
|
|
def test_conditional_value_with_zero(self):
|
|
self.assertEqual(replace_env_vars("${env.ZERO_VAR:+conditional}"), "conditional")
|
|
|
|
def test_mixed_syntax(self):
|
|
self.assertEqual(
|
|
replace_env_vars("${env.TEST_VAR:=default} and ${env.NOT_SET:+conditional}"), "test_value and "
|
|
)
|
|
self.assertEqual(
|
|
replace_env_vars("${env.NOT_SET:=default} and ${env.TEST_VAR:+conditional}"), "default and conditional"
|
|
)
|
|
|
|
def test_nested_structures(self):
|
|
data = {
|
|
"key1": "${env.TEST_VAR:=default}",
|
|
"key2": ["${env.NOT_SET:=default}", "${env.TEST_VAR:+conditional}"],
|
|
"key3": {"nested": "${env.NOT_SET:+conditional}"},
|
|
}
|
|
expected = {"key1": "test_value", "key2": ["default", "conditional"], "key3": {"nested": None}}
|
|
self.assertEqual(replace_env_vars(data), expected)
|
|
|
|
|
|
if __name__ == "__main__":
|
|
unittest.main()
|