mirror of
https://github.com/meta-llama/llama-stack.git
synced 2025-12-17 13:22:36 +00:00
Signed-off-by: Francisco Javier Arceo <farceo@redhat.com> chore: Enable keyword search for Milvus inline (#3073) With https://github.com/milvus-io/milvus-lite/pull/294 - Milvus Lite supports keyword search using BM25. While introducing keyword search we had explicitly disabled it for inline milvus. This PR removes the need for the check, and enables `inline::milvus` for tests. <!-- If resolving an issue, uncomment and update the line below --> <!-- Closes #[issue-number] --> Run llama stack with `inline::milvus` enabled: ``` pytest tests/integration/vector_io/test_openai_vector_stores.py::test_openai_vector_store_search_modes --stack-config=http://localhost:8321 --embedding-model=all-MiniLM-L6-v2 -v ``` ``` INFO 2025-08-07 17:06:20,932 tests.integration.conftest:64 tests: Setting DISABLE_CODE_SANDBOX=1 for macOS =========================================================================================== test session starts ============================================================================================ platform darwin -- Python 3.12.11, pytest-7.4.4, pluggy-1.5.0 -- /Users/vnarsing/miniconda3/envs/stack-client/bin/python cachedir: .pytest_cache metadata: {'Python': '3.12.11', 'Platform': 'macOS-14.7.6-arm64-arm-64bit', 'Packages': {'pytest': '7.4.4', 'pluggy': '1.5.0'}, 'Plugins': {'asyncio': '0.23.8', 'cov': '6.0.0', 'timeout': '2.2.0', 'socket': '0.7.0', 'html': '3.1.1', 'langsmith': '0.3.39', 'anyio': '4.8.0', 'metadata': '3.0.0'}} rootdir: /Users/vnarsing/go/src/github/meta-llama/llama-stack configfile: pyproject.toml plugins: asyncio-0.23.8, cov-6.0.0, timeout-2.2.0, socket-0.7.0, html-3.1.1, langsmith-0.3.39, anyio-4.8.0, metadata-3.0.0 asyncio: mode=Mode.AUTO collected 3 items tests/integration/vector_io/test_openai_vector_stores.py::test_openai_vector_store_search_modes[None-None-all-MiniLM-L6-v2-None-384-vector] PASSED [ 33%] tests/integration/vector_io/test_openai_vector_stores.py::test_openai_vector_store_search_modes[None-None-all-MiniLM-L6-v2-None-384-keyword] PASSED [ 66%] tests/integration/vector_io/test_openai_vector_stores.py::test_openai_vector_store_search_modes[None-None-all-MiniLM-L6-v2-None-384-hybrid] PASSED [100%] ============================================================================================ 3 passed in 4.75s ============================================================================================= ``` Signed-off-by: Varsha Prasad Narsing <varshaprasad96@gmail.com> Co-authored-by: Francisco Arceo <arceofrancisco@gmail.com> chore: Fixup main pre commit (#3204) build: Bump version to 0.2.18 chore: Faster npm pre-commit (#3206) Adds npm to pre-commit.yml installation and caches ui Removes node installation during pre-commit. <!-- If resolving an issue, uncomment and update the line below --> <!-- Closes #[issue-number] --> <!-- Describe the tests you ran to verify your changes with result summaries. *Provide clear instructions so the plan can be easily re-executed.* --> Signed-off-by: Francisco Javier Arceo <farceo@redhat.com> chiecking in for tonight, wip moving to agents api Signed-off-by: Francisco Javier Arceo <farceo@redhat.com> remove log Signed-off-by: Francisco Javier Arceo <farceo@redhat.com> updated Signed-off-by: Francisco Javier Arceo <farceo@redhat.com> fix: disable ui-prettier & ui-eslint (#3207) chore(pre-commit): add pre-commit hook to enforce llama_stack logger usage (#3061) This PR adds a step in pre-commit to enforce using `llama_stack` logger. Currently, various parts of the code base uses different loggers. As a custom `llama_stack` logger exist and used in the codebase, it is better to standardize its utilization. Signed-off-by: Mustafa Elbehery <melbeher@redhat.com> Co-authored-by: Matthew Farrellee <matt@cs.wisc.edu> fix: fix ```openai_embeddings``` for asymmetric embedding NIMs (#3205) NVIDIA asymmetric embedding models (e.g., `nvidia/llama-3.2-nv-embedqa-1b-v2`) require an `input_type` parameter not present in the standard OpenAI embeddings API. This PR adds the `input_type="query"` as default and updates the documentation to suggest using the `embedding` API for passage embeddings. <!-- If resolving an issue, uncomment and update the line below --> Resolves #2892 ``` pytest -s -v tests/integration/inference/test_openai_embeddings.py --stack-config="inference=nvidia" --embedding-model="nvidia/llama-3.2-nv-embedqa-1b-v2" --env NVIDIA_API_KEY={nvidia_api_key} --env NVIDIA_BASE_URL="https://integrate.api.nvidia.com" ``` cleaning up Signed-off-by: Francisco Javier Arceo <farceo@redhat.com> updating session manager to cache messages locally Signed-off-by: Francisco Javier Arceo <farceo@redhat.com> fix linter Signed-off-by: Francisco Javier Arceo <farceo@redhat.com> more cleanup Signed-off-by: Francisco Javier Arceo <farceo@redhat.com>
345 lines
9.3 KiB
TypeScript
345 lines
9.3 KiB
TypeScript
import React from "react";
|
|
import { render, screen, waitFor, act } from "@testing-library/react";
|
|
import "@testing-library/jest-dom";
|
|
import { SessionManager, SessionUtils } from "./session-manager";
|
|
import type { Message } from "@/components/chat-playground/chat-message";
|
|
|
|
interface ChatSession {
|
|
id: string;
|
|
name: string;
|
|
messages: Message[];
|
|
selectedModel: string;
|
|
systemMessage: string;
|
|
agentId: string;
|
|
createdAt: number;
|
|
updatedAt: number;
|
|
}
|
|
|
|
const mockOnSessionChange = jest.fn();
|
|
const mockOnNewSession = jest.fn();
|
|
|
|
// Mock the auth client
|
|
const mockClient = {
|
|
agents: {
|
|
session: {
|
|
list: jest.fn(),
|
|
create: jest.fn(),
|
|
delete: jest.fn(),
|
|
retrieve: jest.fn(),
|
|
},
|
|
},
|
|
};
|
|
|
|
// Mock the useAuthClient hook
|
|
jest.mock("@/hooks/use-auth-client", () => ({
|
|
useAuthClient: jest.fn(() => mockClient),
|
|
}));
|
|
|
|
// Mock additional SessionUtils methods that are now being used
|
|
jest.mock("./session-manager", () => {
|
|
const actual = jest.requireActual("./session-manager");
|
|
return {
|
|
...actual,
|
|
SessionUtils: {
|
|
...actual.SessionUtils,
|
|
saveSessionData: jest.fn(),
|
|
loadSessionData: jest.fn(),
|
|
saveAgentConfig: jest.fn(),
|
|
loadAgentConfig: jest.fn(),
|
|
clearAgentCache: jest.fn(),
|
|
},
|
|
};
|
|
});
|
|
|
|
const localStorageMock = {
|
|
getItem: jest.fn(),
|
|
setItem: jest.fn(),
|
|
removeItem: jest.fn(),
|
|
clear: jest.fn(),
|
|
};
|
|
|
|
Object.defineProperty(window, "localStorage", {
|
|
value: localStorageMock,
|
|
writable: true,
|
|
});
|
|
|
|
// Mock crypto.randomUUID for test environment
|
|
let uuidCounter = 0;
|
|
Object.defineProperty(globalThis, "crypto", {
|
|
value: {
|
|
randomUUID: jest.fn(() => `test-uuid-${++uuidCounter}`),
|
|
},
|
|
writable: true,
|
|
});
|
|
|
|
describe("SessionManager", () => {
|
|
const mockSession: ChatSession = {
|
|
id: "session_123",
|
|
name: "Test Session",
|
|
messages: [
|
|
{
|
|
id: "msg_1",
|
|
role: "user",
|
|
content: "Hello",
|
|
createdAt: new Date(),
|
|
},
|
|
],
|
|
selectedModel: "test-model",
|
|
systemMessage: "You are a helpful assistant.",
|
|
agentId: "agent_123",
|
|
createdAt: 1710000000,
|
|
updatedAt: 1710001000,
|
|
};
|
|
|
|
const mockAgentSessions = [
|
|
{
|
|
session_id: "session_123",
|
|
session_name: "Test Session",
|
|
started_at: "2024-01-01T00:00:00Z",
|
|
turns: [],
|
|
},
|
|
{
|
|
session_id: "session_456",
|
|
session_name: "Another Session",
|
|
started_at: "2024-01-01T01:00:00Z",
|
|
turns: [],
|
|
},
|
|
];
|
|
|
|
beforeEach(() => {
|
|
jest.clearAllMocks();
|
|
localStorageMock.getItem.mockReturnValue(null);
|
|
localStorageMock.setItem.mockImplementation(() => {});
|
|
mockClient.agents.session.list.mockResolvedValue({
|
|
data: mockAgentSessions,
|
|
});
|
|
mockClient.agents.session.create.mockResolvedValue({
|
|
session_id: "new_session_123",
|
|
});
|
|
mockClient.agents.session.delete.mockResolvedValue(undefined);
|
|
mockClient.agents.session.retrieve.mockResolvedValue({
|
|
session_id: "test-session",
|
|
session_name: "Test Session",
|
|
started_at: new Date().toISOString(),
|
|
turns: [],
|
|
});
|
|
uuidCounter = 0; // Reset UUID counter for consistent test behavior
|
|
});
|
|
|
|
describe("Component Rendering", () => {
|
|
test("does not render when no agent is selected", async () => {
|
|
const { container } = await act(async () => {
|
|
return render(
|
|
<SessionManager
|
|
selectedAgentId=""
|
|
currentSession={null}
|
|
onSessionChange={mockOnSessionChange}
|
|
onNewSession={mockOnNewSession}
|
|
/>
|
|
);
|
|
});
|
|
|
|
expect(container.firstChild).toBeNull();
|
|
});
|
|
|
|
test("renders loading state initially", async () => {
|
|
mockClient.agents.session.list.mockImplementation(
|
|
() => new Promise(() => {}) // Never resolves to simulate loading
|
|
);
|
|
|
|
await act(async () => {
|
|
render(
|
|
<SessionManager
|
|
selectedAgentId="agent_123"
|
|
currentSession={null}
|
|
onSessionChange={mockOnSessionChange}
|
|
onNewSession={mockOnNewSession}
|
|
/>
|
|
);
|
|
});
|
|
|
|
expect(screen.getByText("Select Session")).toBeInTheDocument();
|
|
// When loading, the "+ New" button should be disabled
|
|
expect(screen.getByText("+ New")).toBeDisabled();
|
|
});
|
|
|
|
test("renders session selector when agent sessions are loaded", async () => {
|
|
await act(async () => {
|
|
render(
|
|
<SessionManager
|
|
selectedAgentId="agent_123"
|
|
currentSession={null}
|
|
onSessionChange={mockOnSessionChange}
|
|
onNewSession={mockOnNewSession}
|
|
/>
|
|
);
|
|
});
|
|
|
|
await waitFor(() => {
|
|
expect(screen.getByText("Select Session")).toBeInTheDocument();
|
|
});
|
|
});
|
|
|
|
test("renders current session name when session is selected", async () => {
|
|
await act(async () => {
|
|
render(
|
|
<SessionManager
|
|
selectedAgentId="agent_123"
|
|
currentSession={mockSession}
|
|
onSessionChange={mockOnSessionChange}
|
|
onNewSession={mockOnNewSession}
|
|
/>
|
|
);
|
|
});
|
|
|
|
await waitFor(() => {
|
|
expect(screen.getByText("Test Session")).toBeInTheDocument();
|
|
});
|
|
});
|
|
});
|
|
|
|
describe("Agent API Integration", () => {
|
|
test("loads sessions from agent API on mount", async () => {
|
|
await act(async () => {
|
|
render(
|
|
<SessionManager
|
|
selectedAgentId="agent_123"
|
|
currentSession={mockSession}
|
|
onSessionChange={mockOnSessionChange}
|
|
onNewSession={mockOnNewSession}
|
|
/>
|
|
);
|
|
});
|
|
|
|
await waitFor(() => {
|
|
expect(mockClient.agents.session.list).toHaveBeenCalledWith(
|
|
"agent_123"
|
|
);
|
|
});
|
|
});
|
|
|
|
test("handles API errors gracefully", async () => {
|
|
mockClient.agents.session.list.mockRejectedValue(new Error("API Error"));
|
|
const consoleSpy = jest
|
|
.spyOn(console, "error")
|
|
.mockImplementation(() => {});
|
|
|
|
await act(async () => {
|
|
render(
|
|
<SessionManager
|
|
selectedAgentId="agent_123"
|
|
currentSession={mockSession}
|
|
onSessionChange={mockOnSessionChange}
|
|
onNewSession={mockOnNewSession}
|
|
/>
|
|
);
|
|
});
|
|
|
|
await waitFor(() => {
|
|
expect(consoleSpy).toHaveBeenCalledWith(
|
|
"Error loading agent sessions:",
|
|
expect.any(Error)
|
|
);
|
|
});
|
|
|
|
consoleSpy.mockRestore();
|
|
});
|
|
});
|
|
|
|
describe("Error Handling", () => {
|
|
test("component renders without crashing when API is unavailable", async () => {
|
|
mockClient.agents.session.list.mockRejectedValue(
|
|
new Error("Network Error")
|
|
);
|
|
const consoleSpy = jest
|
|
.spyOn(console, "error")
|
|
.mockImplementation(() => {});
|
|
|
|
await act(async () => {
|
|
render(
|
|
<SessionManager
|
|
selectedAgentId="agent_123"
|
|
currentSession={mockSession}
|
|
onSessionChange={mockOnSessionChange}
|
|
onNewSession={mockOnNewSession}
|
|
/>
|
|
);
|
|
});
|
|
|
|
// Should still render the session manager with the select trigger
|
|
expect(screen.getByRole("combobox")).toBeInTheDocument();
|
|
expect(screen.getByText("+ New")).toBeInTheDocument();
|
|
consoleSpy.mockRestore();
|
|
});
|
|
});
|
|
});
|
|
|
|
describe("SessionUtils", () => {
|
|
beforeEach(() => {
|
|
jest.clearAllMocks();
|
|
localStorageMock.getItem.mockReturnValue(null);
|
|
localStorageMock.setItem.mockImplementation(() => {});
|
|
});
|
|
|
|
describe("saveCurrentSessionId", () => {
|
|
test("saves session ID to localStorage", () => {
|
|
SessionUtils.saveCurrentSessionId("test-session-id");
|
|
|
|
expect(localStorageMock.setItem).toHaveBeenCalledWith(
|
|
"chat-playground-current-session",
|
|
"test-session-id"
|
|
);
|
|
});
|
|
});
|
|
|
|
describe("createDefaultSession", () => {
|
|
test("creates default session with agent ID", () => {
|
|
const result = SessionUtils.createDefaultSession("agent_123");
|
|
|
|
expect(result).toEqual(
|
|
expect.objectContaining({
|
|
name: "Default Session",
|
|
messages: [],
|
|
selectedModel: "",
|
|
systemMessage: "You are a helpful assistant.",
|
|
agentId: "agent_123",
|
|
})
|
|
);
|
|
expect(result.id).toBeTruthy();
|
|
expect(result.createdAt).toBeTruthy();
|
|
expect(result.updatedAt).toBeTruthy();
|
|
});
|
|
|
|
test("creates default session with inherited model", () => {
|
|
const result = SessionUtils.createDefaultSession(
|
|
"agent_123",
|
|
"inherited-model"
|
|
);
|
|
|
|
expect(result.selectedModel).toBe("inherited-model");
|
|
expect(result.agentId).toBe("agent_123");
|
|
});
|
|
|
|
test("creates unique session IDs", () => {
|
|
const originalNow = Date.now;
|
|
let mockTime = 1710005000;
|
|
Date.now = jest.fn(() => ++mockTime);
|
|
|
|
const session1 = SessionUtils.createDefaultSession("agent_123");
|
|
const session2 = SessionUtils.createDefaultSession("agent_123");
|
|
|
|
expect(session1.id).not.toBe(session2.id);
|
|
|
|
Date.now = originalNow;
|
|
});
|
|
|
|
test("sets creation and update timestamps", () => {
|
|
const result = SessionUtils.createDefaultSession("agent_123");
|
|
|
|
expect(result.createdAt).toBeTruthy();
|
|
expect(result.updatedAt).toBeTruthy();
|
|
expect(typeof result.createdAt).toBe("number");
|
|
expect(typeof result.updatedAt).toBe("number");
|
|
});
|
|
});
|
|
});
|