From 397ee71c14b7ffc02f446acfaacecb76ae6ba6fa Mon Sep 17 00:00:00 2001 From: Yuri Shkuro Date: Sun, 8 Dec 2024 19:29:53 -0400 Subject: [PATCH] Fix Jaeger instructions (#580) # What does this PR do? - A follow-up for #572 - The command in the original PR did not run - Remove `--set` command unnecessary since Jaeger 2.1.0 ## Test Plan ``` $ docker run --rm --name jaeger \ -p 16686:16686 -p 4318:4318 \ jaegertracing/jaeger:2.1.0 2024/12/07 19:07:13 application version: git-commit=65cff3c30823ea20d3dc48bae39d5685ae307da5, git-version=v2.1.0, build-date=2024-12-06T21:17:15Z ... ``` ## Before submitting - [x] This PR fixes a typo or improves the docs (you can dismiss the other checks if that's the case). - [ ] Ran pre-commit to handle lint / formatting issues. - [x] Read the [contributor guideline](https://github.com/meta-llama/llama-stack/blob/main/CONTRIBUTING.md), Pull Request section? - [x] Updated relevant documentation. - [ ] Wrote necessary unit or integration tests. Signed-off-by: Yuri Shkuro --- docs/source/building_applications/telemetry.md | 11 +++++------ 1 file changed, 5 insertions(+), 6 deletions(-) diff --git a/docs/source/building_applications/telemetry.md b/docs/source/building_applications/telemetry.md index fd4446ed2..6c8067035 100644 --- a/docs/source/building_applications/telemetry.md +++ b/docs/source/building_applications/telemetry.md @@ -40,7 +40,7 @@ structured_log_event = SpanStartPayload( - **Traces**: Collection of related spans forming a complete request flow ### Sinks -- **OpenTelemetry**: Send events to an OpenTelemetry Collector. This is useful for visualizing traces in a service like Jaeger. +- **OpenTelemetry**: Send events to an OpenTelemetry Collector. This is useful for visualizing traces in a tool like Jaeger. - **SQLite**: Store events in a local SQLite database. This is needed if you want to query the events later through the Llama Stack API. - **Console**: Print events to the console. @@ -124,13 +124,12 @@ The `otel` sink works with any service compatible with the OpenTelemetry collect Start a Jaeger instance with the OTLP HTTP endpoint at 4318 and the Jaeger UI at 16686 using the following command: ```bash -$ docker run --rm \ - --name jaeger jaegertracing/jaeger:2.0.0 \ - -p 16686:16686 -p 4318:4318 \ - --set receivers.otlp.protocols.http.endpoint=0.0.0.0:4318 +$ docker run --rm --name jaeger \ + -p 16686:16686 -p 4318:4318 \ + jaegertracing/jaeger:2.1.0 ``` -Once the Jaeger instance is running, you can visualize traces by navigating to http://localhost:16686. +Once the Jaeger instance is running, you can visualize traces by navigating to http://localhost:16686/. ## Querying Traces Stored in SQLIte