From 5c8e35a9e280cda6e8bffb6ff7b6b0dee6519545 Mon Sep 17 00:00:00 2001 From: Ihar Hrachyshka Date: Wed, 5 Feb 2025 11:25:56 -0500 Subject: [PATCH] docs, tests: replace datasets.rst with memory_optimizations.rst (#968) datasets.rst was removed from torchtune repo. Signed-off-by: Ihar Hrachyshka # What does this PR do? Replace a missing 404 document with another one that exists. (Removed it from the list when memory_optimizations.rst was already pulled.) ## Test Plan Please describe: - tests you ran to verify your changes with result summaries. - provide instructions so it can be reproduced. ## Sources Please link relevant resources if necessary. ## Before submitting - [x] This PR fixes a typo or improves the docs (you can dismiss the other checks if that's the case). - [x] Ran pre-commit to handle lint / formatting issues. - [ ] Read the [contributor guideline](https://github.com/meta-llama/llama-stack/blob/main/CONTRIBUTING.md), Pull Request section? - [ ] Updated relevant documentation. - [ ] Wrote necessary unit or integration tests. Signed-off-by: Ihar Hrachyshka --- docs/getting_started.ipynb | 2 +- docs/source/getting_started/index.md | 2 +- llama_stack/providers/tests/agents/test_agents.py | 1 - llama_stack/providers/tests/tools/test_tools.py | 1 - tests/client-sdk/agents/test_agents.py | 2 +- 5 files changed, 3 insertions(+), 5 deletions(-) diff --git a/docs/getting_started.ipynb b/docs/getting_started.ipynb index dadc0ba42..3087a2b3b 100644 --- a/docs/getting_started.ipynb +++ b/docs/getting_started.ipynb @@ -1662,7 +1662,7 @@ "from termcolor import cprint\n", "from llama_stack_client.types import Document\n", "\n", - "urls = [\"chat.rst\", \"llama3.rst\", \"datasets.rst\", \"lora_finetune.rst\"]\n", + "urls = [\"chat.rst\", \"llama3.rst\", \"memory_optimizations.rst\", \"lora_finetune.rst\"]\n", "documents = [\n", " Document(\n", " document_id=f\"num-{i}\",\n", diff --git a/docs/source/getting_started/index.md b/docs/source/getting_started/index.md index 1da0b8ae3..1ddc5ff54 100644 --- a/docs/source/getting_started/index.md +++ b/docs/source/getting_started/index.md @@ -185,7 +185,7 @@ client = ( ) # or create_http_client() depending on the environment you picked # Documents to be used for RAG -urls = ["chat.rst", "llama3.rst", "datasets.rst", "lora_finetune.rst"] +urls = ["chat.rst", "llama3.rst", "memory_optimizations.rst", "lora_finetune.rst"] documents = [ Document( document_id=f"num-{i}", diff --git a/llama_stack/providers/tests/agents/test_agents.py b/llama_stack/providers/tests/agents/test_agents.py index da29cf09f..37d0c04b5 100644 --- a/llama_stack/providers/tests/agents/test_agents.py +++ b/llama_stack/providers/tests/agents/test_agents.py @@ -152,7 +152,6 @@ class TestAgents: "memory_optimizations.rst", "chat.rst", "llama3.rst", - "datasets.rst", "qat_finetune.rst", "lora_finetune.rst", ] diff --git a/llama_stack/providers/tests/tools/test_tools.py b/llama_stack/providers/tests/tools/test_tools.py index c794441b2..8188f3dd7 100644 --- a/llama_stack/providers/tests/tools/test_tools.py +++ b/llama_stack/providers/tests/tools/test_tools.py @@ -28,7 +28,6 @@ def sample_documents(): "memory_optimizations.rst", "chat.rst", "llama3.rst", - "datasets.rst", "qat_finetune.rst", "lora_finetune.rst", ] diff --git a/tests/client-sdk/agents/test_agents.py b/tests/client-sdk/agents/test_agents.py index 7a62da35f..ed599e43d 100644 --- a/tests/client-sdk/agents/test_agents.py +++ b/tests/client-sdk/agents/test_agents.py @@ -264,7 +264,7 @@ def test_custom_tool(llama_stack_client, agent_config): def test_rag_agent(llama_stack_client, agent_config): - urls = ["chat.rst", "llama3.rst", "datasets.rst", "lora_finetune.rst"] + urls = ["chat.rst", "llama3.rst", "memory_optimizations.rst", "lora_finetune.rst"] documents = [ Document( document_id=f"num-{i}",