phoenix-oss/llama-stack
1
0
Fork 0
forked from phoenix-oss/llama-stack-mirror
Code Pull requests Releases Packages 2 Activity Actions

fix: Fixed bad file name in inline::localfs (#1358)

Browse source 
Bug https://github.com/meta-llama/llama-stack/issues/1357

# What does this PR do?
Fix a bug of a wrong file name in inline::localfs datasetio provider

[//]: # (If resolving an issue, uncomment and update the line below)
# (Closes #1357)

## Test Plan
[Describe the tests you ran to verify your changes with result
summaries. *Provide clear instructions so the plan can be easily
re-executed.*]

[//]: # (## Documentation)

Signed-off-by: Josh Salomon <jsalomon@redhat.com>
This commit is contained in:
Josh Salomon 2025-03-11 21:46:11 +02:00 • committed by GitHub
parent 43044f29e2
commit 5f90be5388
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
2 changed files with 1 additions and 2 deletions
Download patch file Download diff file Expand all files Collapse all files

1
distributions/remote-vllm/compose.yaml
View file

@ -71,7 +71,6 @@ services:
condition: service_healthy condition: service_healthy
- vllm-${VLLM_SAFETY_MODEL:+safety}: - vllm-${VLLM_SAFETY_MODEL:+safety}:
condition: service_healthy condition: service_healthy
# image: llamastack/distribution-remote-vllm
image: llamastack/distribution-remote-vllm:test-0.0.52rc3 image: llamastack/distribution-remote-vllm:test-0.0.52rc3
volumes: volumes:
- ~/.llama:/root/.llama - ~/.llama:/root/.llama

2
llama_stack/providers/inline/datasetio/localfs/datasetio.py
View file

@ -172,7 +172,7 @@ class LocalFSDatasetIOImpl(DatasetIO, DatasetsProtocolPrivate):
new_rows_df = dataset_impl._validate_dataset_schema(new_rows_df) new_rows_df = dataset_impl._validate_dataset_schema(new_rows_df)
dataset_impl.df = pandas.concat([dataset_impl.df, new_rows_df], ignore_index=True) dataset_impl.df = pandas.concat([dataset_impl.df, new_rows_df], ignore_index=True)
url = str(dataset_info.dataset_def.url) url = str(dataset_info.dataset_def.url.uri)
parsed_url = urlparse(url) parsed_url = urlparse(url)
if parsed_url.scheme == "file" or not parsed_url.scheme: if parsed_url.scheme == "file" or not parsed_url.scheme: