From 64328bfe625647389ef1731ae7f090c88404f1a3 Mon Sep 17 00:00:00 2001
From: Yuan Tang <terrytangyuan@gmail.com>
Date: Fri, 14 Feb 2025 12:19:53 -0500
Subject: [PATCH] fix: enable_session_persistence in AgentConfig should be
 optional (#1012)

# What does this PR do?
This issue was discovered in
https://github.com/meta-llama/llama-stack/pull/1009#discussion_r1947036518.

## Test Plan

This field is no longer required after the change.

[//]: # (## Documentation)
[//]: # (- [ ] Added a Changelog entry if the change is significant)

---------

Signed-off-by: Yuan Tang <terrytangyuan@gmail.com>
Co-authored-by: Ashwin Bharambe <ashwin.bharambe@gmail.com>
---
 docs/_static/llama-stack-spec.html | 6 +++---
 docs/_static/llama-stack-spec.yaml | 2 +-
 llama_stack/apis/agents/agents.py  | 2 +-
 3 files changed, 5 insertions(+), 5 deletions(-)

diff --git a/docs/_static/llama-stack-spec.html b/docs/_static/llama-stack-spec.html
index 026a061c8..17cf92341 100644
--- a/docs/_static/llama-stack-spec.html
+++ b/docs/_static/llama-stack-spec.html
@@ -2724,7 +2724,8 @@
                         "type": "string"
                     },
                     "enable_session_persistence": {
-                        "type": "boolean"
+                        "type": "boolean",
+                        "default": false
                     },
                     "response_format": {
                         "$ref": "#/components/schemas/ResponseFormat"
@@ -2733,8 +2734,7 @@
                 "additionalProperties": false,
                 "required": [
                     "model",
-                    "instructions",
-                    "enable_session_persistence"
+                    "instructions"
                 ]
             },
             "AgentTool": {
diff --git a/docs/_static/llama-stack-spec.yaml b/docs/_static/llama-stack-spec.yaml
index e4f0398c0..f63374406 100644
--- a/docs/_static/llama-stack-spec.yaml
+++ b/docs/_static/llama-stack-spec.yaml
@@ -1660,13 +1660,13 @@ components:
           type: string
         enable_session_persistence:
           type: boolean
+          default: false
         response_format:
           $ref: '#/components/schemas/ResponseFormat'
       additionalProperties: false
       required:
         - model
         - instructions
-        - enable_session_persistence
     AgentTool:
       oneOf:
         - type: string
diff --git a/llama_stack/apis/agents/agents.py b/llama_stack/apis/agents/agents.py
index ccd15c3d6..367648ded 100644
--- a/llama_stack/apis/agents/agents.py
+++ b/llama_stack/apis/agents/agents.py
@@ -179,7 +179,7 @@ class AgentConfigCommon(BaseModel):
 class AgentConfig(AgentConfigCommon):
     model: str
     instructions: str
-    enable_session_persistence: bool
+    enable_session_persistence: Optional[bool] = False
     response_format: Optional[ResponseFormat] = None