phoenix-oss/llama-stack
1
0
Fork 0
forked from phoenix-oss/llama-stack-mirror
Code Pull requests Releases Packages 2 Activity Actions

Properly close PGVector DB connection during shutdown() (#931)

Browse source 
The connection to the DB was not closed during shutdown.

Signed-off-by: Yuan Tang <terrytangyuan@gmail.com>
This commit is contained in:
Yuan Tang 2025-02-03 00:23:13 -05:00 • committed by GitHub
parent ccf0cbb903
commit 83a51c7bfb
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
1 changed files with 3 additions and 1 deletions
Download patch file Download diff file Expand all files Collapse all files

4
llama_stack/providers/remote/vector_io/pgvector/pgvector.py
View file

@ -158,7 +158,9 @@ class PGVectorVectorDBAdapter(VectorIO, VectorDBsProtocolPrivate):
raise RuntimeError("Could not connect to PGVector database server") from e
async def shutdown(self) -> None:
pass
if self.conn is not None:
self.conn.close()
log.info("Connection to PGVector database server closed")
async def register_vector_db(self, vector_db: VectorDB) -> None:
upsert_models(self.cursor, [(vector_db.identifier, vector_db)])