phoenix-oss/llama-stack
1
0
Fork 0
forked from phoenix-oss/llama-stack-mirror
Code Pull requests Releases Packages 2 Activity Actions

fix: a couple of tests were broken and not yet exercised by our per-PR test workflow

Browse source
This commit is contained in:
Ashwin Bharambe 2025-03-21 12:11:50 -07:00
parent 34f89bfbd6
commit d6887f46c6
2 changed files with 8 additions and 6 deletions
Download patch file Download diff file Expand all files Collapse all files

3
llama_stack/providers/inline/scoring/basic/scoring_fn/ifeval_scoring_fn.py
View file

@ -10,7 +10,6 @@ from llama_stack.apis.scoring import ScoringResultRow
from llama_stack.apis.scoring_functions import ScoringFnParams from llama_stack.apis.scoring_functions import ScoringFnParams
from llama_stack.providers.utils.scoring.base_scoring_fn import RegisteredBaseScoringFn from llama_stack.providers.utils.scoring.base_scoring_fn import RegisteredBaseScoringFn
from ..utils.ifeval_utils import INSTRUCTION_DICT, INSTRUCTION_LIST
from .fn_defs.ifeval import ( from .fn_defs.ifeval import (
ifeval, ifeval,
) )
@ -33,6 +32,8 @@ class IfEvalScoringFn(RegisteredBaseScoringFn):
scoring_fn_identifier: Optional[str] = None, scoring_fn_identifier: Optional[str] = None,
scoring_params: Optional[ScoringFnParams] = None, scoring_params: Optional[ScoringFnParams] = None,
) -> ScoringResultRow: ) -> ScoringResultRow:
from ..utils.ifeval_utils import INSTRUCTION_DICT, INSTRUCTION_LIST
assert scoring_fn_identifier is not None, "Scoring function identifier not found." assert scoring_fn_identifier is not None, "Scoring function identifier not found."
fn_def = self.supported_fn_defs_registry[scoring_fn_identifier] fn_def = self.supported_fn_defs_registry[scoring_fn_identifier]
if scoring_params is not None: if scoring_params is not None:

11
tests/integration/providers/test_providers.py
View file

@ -12,11 +12,12 @@ from llama_stack import LlamaStackAsLibraryClient
class TestProviders: class TestProviders:
@pytest.mark.asyncio @pytest.mark.asyncio
def test_list(self, llama_stack_client: LlamaStackAsLibraryClient | LlamaStackClient): def test_providers(self, llama_stack_client: LlamaStackAsLibraryClient | LlamaStackClient):
provider_list = llama_stack_client.providers.list() provider_list = llama_stack_client.providers.list()
assert provider_list is not None assert provider_list is not None
assert len(provider_list) > 0
@pytest.mark.asyncio for provider in provider_list:
def test_inspect(self, llama_stack_client: LlamaStackAsLibraryClient | LlamaStackClient): pid = provider.provider_id
provider_list = llama_stack_client.providers.retrieve("ollama") provider = llama_stack_client.providers.retrieve(pid)
assert provider_list is not None assert provider is not None