phoenix-oss/llama-stack
1
0
Fork 0
forked from phoenix-oss/llama-stack-mirror
Code Pull requests Releases Packages 2 Activity Actions

feat: make telemetry attributes be dict[str,PrimitiveType] (#1055)

Browse source 
# What does this PR do?
Make attributes in telemetry be only primitive types and avoid arbitrary
nesting.

## Test Plan
```
 LLAMA_STACK_DISABLE_VERSION_CHECK=true llama stack run ~/.llama/distributions/fireworks/fireworks-run.yaml
LLAMA_STACK_BASE_URL=http://localhost:8321 pytest -v tests/client-sdk/agents/test_agents.py  -k "test_builtin_tool_web_search"
# Verified that attributes still show up correclty in jaeger
```
This commit is contained in:
Dinesh Yeduguru 2025-02-11 15:10:17 -08:00 • committed by GitHub
parent ab7f802698
commit d8a20e034b
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
4 changed files with 29 additions and 45 deletions
Download patch file Download diff file Expand all files Collapse all files

36
docs/_static/llama-stack-spec.html vendored
View file

@ -3148,22 +3148,19 @@
"additionalProperties": {
"oneOf": [
{
"type": "null"
"type": "string"
},
{
"type": "boolean"
"type": "integer"
},
{
"type": "number"
},
{
"type": "string"
"type": "boolean"
},
{
"type": "array"
},
{
"type": "object"
"type": "null"
}
]
}
@ -3683,8 +3680,7 @@
"auto",
"required"
],
"description": "Whether tool use is required or automatic. This is a hint to the model which may not be followed. It depends on the Instruction Following capabilities of the model.",
"default": "auto"
"description": "Whether tool use is required or automatic. This is a hint to the model which may not be followed. It depends on the Instruction Following capabilities of the model."
},
"tool_prompt_format": {
"type": "string",
@ -6514,22 +6510,19 @@
"additionalProperties": {
"oneOf": [
{
"type": "null"
"type": "string"
},
{
"type": "boolean"
"type": "integer"
},
{
"type": "number"
},
{
"type": "string"
"type": "boolean"
},
{
"type": "array"
},
{
"type": "object"
"type": "null"
}
]
}
@ -6587,22 +6580,19 @@
"additionalProperties": {
"oneOf": [
{
"type": "null"
"type": "string"
},
{
"type": "boolean"
"type": "integer"
},
{
"type": "number"
},
{
"type": "string"
"type": "boolean"
},
{
"type": "array"
},
{
"type": "object"
"type": "null"
}
]
}