From e58c7f6c373b1d15a45cb299ccfab24120aaa2df Mon Sep 17 00:00:00 2001 From: ehhuang Date: Fri, 28 Mar 2025 14:40:17 -0700 Subject: [PATCH] fix(telemetry): root span not yet received (#1828) # What does this PR do? closes #1725 In https://github.com/meta-llama/llama-stack/pull/1759's attempt to make trace_id consistent in llama stack and otel exports, it incorrectly sets the span_id in context, which causes the root span to have a parent ID, leading to the issue in #1725. This PR reverts #1759's change to set the parent context. We will need to follow up with a proper way to do this. ## Test Plan image --- .../inline/telemetry/meta_reference/telemetry.py | 12 ------------ 1 file changed, 12 deletions(-) diff --git a/llama_stack/providers/inline/telemetry/meta_reference/telemetry.py b/llama_stack/providers/inline/telemetry/meta_reference/telemetry.py index 7e834451d..817085968 100644 --- a/llama_stack/providers/inline/telemetry/meta_reference/telemetry.py +++ b/llama_stack/providers/inline/telemetry/meta_reference/telemetry.py @@ -202,18 +202,6 @@ class TelemetryAdapter(TelemetryDatasetMixin, Telemetry): parent_span_id = int(event.payload.parent_span_id, 16) parent_span = _GLOBAL_STORAGE["active_spans"].get(parent_span_id) context = trace.set_span_in_context(parent_span) - else: - context = trace.set_span_in_context( - trace.NonRecordingSpan( - trace.SpanContext( - trace_id=int(event.trace_id, 16), - span_id=span_id, - is_remote=False, - trace_flags=trace.TraceFlags(trace.TraceFlags.SAMPLED), - ) - ) - ) - event.attributes["__root_span__"] = "true" span = tracer.start_span( name=event.payload.name,