phoenix-oss/llama-stack
1
0
Fork 0
forked from phoenix-oss/llama-stack-mirror
Code Pull requests Releases Packages 2 Activity Actions

[bugfix] fix #146 (#147)

Browse source 
* more robust image type

* lint
This commit is contained in:
Xi Yan 2024-09-28 17:47:00 -07:00 • committed by GitHub
parent b646167d94
commit f6a6598d1a
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
2 changed files with 5 additions and 4 deletions
Download patch file Download diff file Expand all files Collapse all files

2
README.md
View file

@ -82,7 +82,7 @@ $CONDA_PREFIX/bin/pip install -e .
## The Llama CLI ## The Llama CLI
The `llama` CLI makes it easy to work with the Llama Stack set of tools, including installing and running Distributions, downloading models, studying model prompt formats, etc. Please see the [CLI reference](docs/cli_reference.md) for details. Please see the [Getting Started](docs/getting_started.md) guide for running a Llama Stack server. The `llama` CLI makes it easy to work with the Llama Stack set of tools, including installing and running Distributions, downloading models, studying model prompt formats, etc. Please see the [CLI reference](docs/cli_reference.md) for details. Please see the [Getting Started](docs/getting_started.md) guide for running a Llama Stack server.
## Llama Stack Client SDK ## Llama Stack Client SDK

7
llama_stack/cli/stack/build.py
View file

@ -74,8 +74,8 @@ class StackBuild(Subcommand):
self.parser.add_argument( self.parser.add_argument(
"--image-type", "--image-type",
type=str, type=str,
help="Image Type to use for the build. This can be either conda or docker. If not specified, will use conda by default", help="Image Type to use for the build. This can be either conda or docker. If not specified, will use the image type from the template config.",
default="conda", choices=["conda", "docker"],
) )
def _run_stack_build_command_from_build_config( def _run_stack_build_command_from_build_config(
@ -183,7 +183,8 @@ class StackBuild(Subcommand):
with open(build_path, "r") as f: with open(build_path, "r") as f:
build_config = BuildConfig(**yaml.safe_load(f)) build_config = BuildConfig(**yaml.safe_load(f))
build_config.name = args.name build_config.name = args.name
build_config.image_type = args.image_type if args.image_type:
build_config.image_type = args.image_type
self._run_stack_build_command_from_build_config(build_config) self._run_stack_build_command_from_build_config(build_config)
return return