forked from phoenix-oss/llama-stack-mirror
24fd06879e
# What does this PR do? A PTY is unnecessary for interactive mode since `subprocess.run()` already inherits the calling terminal’s stdin, stdout, and stderr, allowing natural interaction. Using a PTY can introduce unwanted side effects like buffering issues and inconsistent signal handling. Standard input/output is sufficient for most interactive programs. This commit simplifies the command execution by: 1. Removing PTY-based execution in favor of direct subprocess handling 2. Consolidating command execution into a single run_command function 3. Improving error handling with specific subprocess error types 4. Adding proper type hints and documentation 5. Maintaining Ctrl+C handling for graceful interruption ## Test Plan ``` llama stack run ``` Signed-off-by: Sébastien Han <seb@redhat.com> |
||
|---|---|---|
| .. | ||
| tests | ||
| __init__.py | ||
| config_dirs.py | ||
| context.py | ||
| dynamic.py | ||
| exec.py | ||
| image_types.py | ||
| model_utils.py | ||
| prompt_for_config.py | ||
| serialize.py | ||