forked from phoenix-oss/llama-stack-mirror
41487e6ed1
# What does this PR do? - remove model registration & parameterize model in scoring/eval pytests ## Test Plan ``` pytest -v -s -m meta_reference_eval_together_inference eval/test_eval.py pytest -v -s -m meta_reference_eval_together_inference_huggingface_datasetio eval/test_eval.py ``` ``` pytest -v -s -m llm_as_judge_scoring_together_inference scoring/test_scoring.py --judge-model meta-llama/Llama-3.2-3B-Instruct pytest -v -s -m basic_scoring_together_inference scoring/test_scoring.py ``` <img width="860" alt="image" src="https://github.com/user-attachments/assets/d4b0badc-da34-4097-9b7c-9511f8261723" /> ## Sources Please link relevant resources if necessary. ## Before submitting - [ ] This PR fixes a typo or improves the docs (you can dismiss the other checks if that's the case). - [ ] Ran pre-commit to handle lint / formatting issues. - [ ] Read the [contributor guideline](https://github.com/meta-llama/llama-stack/blob/main/CONTRIBUTING.md), Pull Request section? - [ ] Updated relevant documentation. - [ ] Wrote necessary unit or integration tests.
92 lines
2.7 KiB
Python
92 lines
2.7 KiB
Python
# Copyright (c) Meta Platforms, Inc. and affiliates.
|
|
# All rights reserved.
|
|
#
|
|
# This source code is licensed under the terms described in the LICENSE file in
|
|
# the root directory of this source tree.
|
|
|
|
import pytest
|
|
|
|
from ..conftest import get_provider_fixture_overrides
|
|
|
|
from ..datasetio.fixtures import DATASETIO_FIXTURES
|
|
from ..inference.fixtures import INFERENCE_FIXTURES
|
|
from .fixtures import SCORING_FIXTURES
|
|
|
|
DEFAULT_PROVIDER_COMBINATIONS = [
|
|
pytest.param(
|
|
{
|
|
"scoring": "basic",
|
|
"datasetio": "localfs",
|
|
"inference": "together",
|
|
},
|
|
id="basic_scoring_together_inference",
|
|
marks=pytest.mark.basic_scoring_together_inference,
|
|
),
|
|
pytest.param(
|
|
{
|
|
"scoring": "braintrust",
|
|
"datasetio": "localfs",
|
|
"inference": "together",
|
|
},
|
|
id="braintrust_scoring_together_inference",
|
|
marks=pytest.mark.braintrust_scoring_together_inference,
|
|
),
|
|
pytest.param(
|
|
{
|
|
"scoring": "llm_as_judge",
|
|
"datasetio": "localfs",
|
|
"inference": "together",
|
|
},
|
|
id="llm_as_judge_scoring_together_inference",
|
|
marks=pytest.mark.llm_as_judge_scoring_together_inference,
|
|
),
|
|
]
|
|
|
|
|
|
def pytest_configure(config):
|
|
for fixture_name in [
|
|
"basic_scoring_together_inference",
|
|
"braintrust_scoring_together_inference",
|
|
"llm_as_judge_scoring_together_inference",
|
|
]:
|
|
config.addinivalue_line(
|
|
"markers",
|
|
f"{fixture_name}: marks tests as {fixture_name} specific",
|
|
)
|
|
|
|
|
|
def pytest_addoption(parser):
|
|
parser.addoption(
|
|
"--inference-model",
|
|
action="store",
|
|
default="meta-llama/Llama-3.2-3B-Instruct",
|
|
help="Specify the inference model to use for testing",
|
|
)
|
|
parser.addoption(
|
|
"--judge-model",
|
|
action="store",
|
|
default="meta-llama/Llama-3.1-8B-Instruct",
|
|
help="Specify the judge model to use for testing",
|
|
)
|
|
|
|
|
|
def pytest_generate_tests(metafunc):
|
|
judge_model = metafunc.config.getoption("--judge-model")
|
|
if "judge_model" in metafunc.fixturenames:
|
|
metafunc.parametrize(
|
|
"judge_model",
|
|
[pytest.param(judge_model, id="")],
|
|
indirect=True,
|
|
)
|
|
|
|
if "scoring_stack" in metafunc.fixturenames:
|
|
available_fixtures = {
|
|
"scoring": SCORING_FIXTURES,
|
|
"datasetio": DATASETIO_FIXTURES,
|
|
"inference": INFERENCE_FIXTURES,
|
|
}
|
|
combinations = (
|
|
get_provider_fixture_overrides(metafunc.config, available_fixtures)
|
|
or DEFAULT_PROVIDER_COMBINATIONS
|
|
)
|
|
metafunc.parametrize("scoring_stack", combinations, indirect=True)
|