forked from phoenix-oss/llama-stack-mirror
c79b087552
# Context For test automation, the end goal is to run a single pytest command from root test directory (llama_stack/providers/tests/.) such that we execute push-blocking tests The work plan: 1) trigger pytest from llama_stack/providers/tests/. 2) use config file to determine what tests and parametrization we want to run # What does this PR do? 1) consolidates the "inference-models" / "embedding-model" / "judge-model" ... options in root conftest.py. Without this change, we will hit into error when trying to run `pytest /Users/sxyi/llama-stack/llama_stack/providers/tests/.` because of duplicated `addoptions` definitions across child conftest files. 2) Add a `config` option to specify test config in YAML. (see [`ci_test_config.yaml`](https://gist.github.com/sixianyi0721/5b37fbce4069139445c2f06f6e42f87e) for example config file) For provider_fixtures, we allow users to use either a default fixture combination or define their own {api:provider} combinations. ``` memory: .... fixtures: provider_fixtures: - default_fixture_param_id: ollama // use default fixture combination with param_id="ollama" in [providers/tests/memory/conftest.py](https://fburl.com/mtjzwsmk) - inference: sentence_transformers memory: faiss - default_fixture_param_id: chroma ``` 3) generate tests according to the config. Logic lives in two places: a) in `{api}/conftest.py::pytest_generate_tests`, we read from config to do parametrization. b) after test collection, in `pytest_collection_modifyitems`, we filter the tests to include only functions listed in config. ## Test Plan 1) `pytest /Users/sxyi/llama-stack/llama_stack/providers/tests/. --collect-only --config=ci_test_config.yaml` Using `--collect-only` tag to print the pytests listed in the config file (`ci_test_config.yaml`). output: [gist](https://gist.github.com/sixianyi0721/05145e60d4d085c17cfb304beeb1e60e) 2) sanity check on `--inference-model` option ``` pytest -v -s -k "ollama" --inference-model="meta-llama/Llama-3.1-8B-Instruct" ./llama_stack/providers/tests/inference/test_text_inference.py ``` ## Before submitting - [ ] This PR fixes a typo or improves the docs (you can dismiss the other checks if that's the case). - [x] Ran pre-commit to handle lint / formatting issues. - [x] Read the [contributor guideline](https://github.com/meta-llama/llama-stack/blob/main/CONTRIBUTING.md), Pull Request section? - [ ] Updated relevant documentation. - [ ] Wrote necessary unit or integration tests.
84 lines
2.6 KiB
Python
84 lines
2.6 KiB
Python
# Copyright (c) Meta Platforms, Inc. and affiliates.
|
|
# All rights reserved.
|
|
#
|
|
# This source code is licensed under the terms described in the LICENSE file in
|
|
# the root directory of this source tree.
|
|
|
|
import pytest
|
|
|
|
from ..conftest import get_provider_fixture_overrides, get_test_config_for_api
|
|
from .fixtures import INFERENCE_FIXTURES
|
|
|
|
|
|
def pytest_configure(config):
|
|
for model in ["llama_8b", "llama_3b", "llama_vision"]:
|
|
config.addinivalue_line(
|
|
"markers", f"{model}: mark test to run only with the given model"
|
|
)
|
|
|
|
for fixture_name in INFERENCE_FIXTURES:
|
|
config.addinivalue_line(
|
|
"markers",
|
|
f"{fixture_name}: marks tests as {fixture_name} specific",
|
|
)
|
|
|
|
|
|
MODEL_PARAMS = [
|
|
pytest.param(
|
|
"meta-llama/Llama-3.1-8B-Instruct", marks=pytest.mark.llama_8b, id="llama_8b"
|
|
),
|
|
pytest.param(
|
|
"meta-llama/Llama-3.2-3B-Instruct", marks=pytest.mark.llama_3b, id="llama_3b"
|
|
),
|
|
]
|
|
|
|
VISION_MODEL_PARAMS = [
|
|
pytest.param(
|
|
"Llama3.2-11B-Vision-Instruct",
|
|
marks=pytest.mark.llama_vision,
|
|
id="llama_vision",
|
|
),
|
|
]
|
|
|
|
|
|
def pytest_generate_tests(metafunc):
|
|
test_config = get_test_config_for_api(metafunc.config, "inference")
|
|
|
|
if "inference_model" in metafunc.fixturenames:
|
|
cls_name = metafunc.cls.__name__
|
|
params = []
|
|
inference_models = getattr(test_config, "inference_models", [])
|
|
for model in inference_models:
|
|
if ("Vision" in cls_name and "Vision" in model) or (
|
|
"Vision" not in cls_name and "Vision" not in model
|
|
):
|
|
params.append(pytest.param(model, id=model))
|
|
|
|
if not params:
|
|
model = metafunc.config.getoption("--inference-model")
|
|
params = [pytest.param(model, id="")]
|
|
|
|
metafunc.parametrize(
|
|
"inference_model",
|
|
params,
|
|
indirect=True,
|
|
)
|
|
if "inference_stack" in metafunc.fixturenames:
|
|
fixtures = INFERENCE_FIXTURES
|
|
if filtered_stacks := get_provider_fixture_overrides(
|
|
metafunc.config,
|
|
{
|
|
"inference": INFERENCE_FIXTURES,
|
|
},
|
|
):
|
|
fixtures = [stack.values[0]["inference"] for stack in filtered_stacks]
|
|
if test_config:
|
|
if custom_fixtures := [
|
|
(
|
|
scenario.fixture_combo_id
|
|
or scenario.provider_fixtures.get("inference")
|
|
)
|
|
for scenario in test_config.scenarios
|
|
]:
|
|
fixtures = custom_fixtures
|
|
metafunc.parametrize("inference_stack", fixtures, indirect=True)
|