From 79be94afd2c863c0a42a09e9e8baf6c247dbc469 Mon Sep 17 00:00:00 2001 From: ThomasTaroni Date: Fri, 25 Apr 2025 19:53:59 +0200 Subject: [PATCH] Refactor generator completion checks for consistency. Replaced `.is_complete()` method calls with direct `.complete` attribute access to streamline the code. Removed the redundant `is_complete()` method from `deepresearch.py` to reduce unnecessary indirection. This simplifies the logic and improves readability. --- src/main.py | 4 ++-- src/phoenix_technologies/gptresearch/deepresearch.py | 3 --- 2 files changed, 2 insertions(+), 5 deletions(-) diff --git a/src/main.py b/src/main.py index 02ca60f..0b432c8 100644 --- a/src/main.py +++ b/src/main.py @@ -42,7 +42,7 @@ async def get_report_endpoint(request: ReportRequest): generator.generate_report() yield "Report generation completed successfully!\n" index = 0 - while not generator.is_complete(): + while not generator.complete: # If there are more logs to send, yield them if index < len(custom_logs_handler.logs): log_entry = custom_logs_handler.logs[index] @@ -52,7 +52,7 @@ async def get_report_endpoint(request: ReportRequest): # Wait briefly to avoid aggressive looping await asyncio.sleep(0.1) # Stop if processing is complete and no more logs remain - if generator.researcher.is_complete(): + if generator.researcher.complete: break except Exception as e: diff --git a/src/phoenix_technologies/gptresearch/deepresearch.py b/src/phoenix_technologies/gptresearch/deepresearch.py index 77ad753..61f1aec 100644 --- a/src/phoenix_technologies/gptresearch/deepresearch.py +++ b/src/phoenix_technologies/gptresearch/deepresearch.py @@ -28,9 +28,6 @@ class ReportGenerator: def init(self) -> CustomLogsHandler: return self.custom_logs_handler - def is_complete(self): - return self.complete - async def generate_report(self) -> None: """ Conducts research and generates the report along with additional information.