phoenix-oss/mcp-remote
0
0
Fork 0
Code Issues Pull requests Projects Releases Packages 1 Wiki Activity Actions

Disabling the multi-popup-prevention logic for now on windows as it appears not to be reliable

Browse source
This commit is contained in:
Glen Maddern 2025-04-04 14:44:56 +11:00
parent 88fa18b1d1
commit 684320a04c
2 changed files with 6 additions and 6 deletions
Download patch file Download diff file Expand all files Collapse all files

2
README.md
View file

@ -130,7 +130,7 @@ Then restarting your MCP client.
### Check your Node version ### Check your Node version
Make sure that the version of Node you have installed is [16 or Make sure that the version of Node you have installed is [18 or
higher](https://modelcontextprotocol.io/quickstart/server). Claude higher](https://modelcontextprotocol.io/quickstart/server). Claude
Desktop will use your system version of Node, even if you have a newer Desktop will use your system version of Node, even if you have a newer
version installed elsewhere. version installed elsewhere.

8
src/lib/coordination.ts
View file

@ -76,7 +76,7 @@ export async function waitForAuthentication(port: number): Promise<boolean> {
} else if (response.status === 202) { } else if (response.status === 202) {
// Continue polling // Continue polling
log(`Authentication still in progress`) log(`Authentication still in progress`)
await new Promise(resolve => setTimeout(resolve, 1000)) await new Promise((resolve) => setTimeout(resolve, 1000))
} else { } else {
log(`Unexpected response status: ${response.status}`) log(`Unexpected response status: ${response.status}`)
return false return false
@ -100,8 +100,8 @@ export async function coordinateAuth(
callbackPort: number, callbackPort: number,
events: EventEmitter, events: EventEmitter,
): Promise<{ server: Server; waitForAuthCode: () => Promise<string>; skipBrowserAuth: boolean }> { ): Promise<{ server: Server; waitForAuthCode: () => Promise<string>; skipBrowserAuth: boolean }> {
// Check for a lockfile // Check for a lockfile (disabled on Windows for the time being)
const lockData = await checkLockfile(serverUrlHash) const lockData = process.platform === 'win32' ? null : await checkLockfile(serverUrlHash)
// If there's a valid lockfile, try to use the existing auth process // If there's a valid lockfile, try to use the existing auth process
if (lockData && (await isLockValid(lockData))) { if (lockData && (await isLockValid(lockData))) {
@ -183,6 +183,6 @@ export async function coordinateAuth(
return { return {
server, server,
waitForAuthCode, waitForAuthCode,
skipBrowserAuth: false skipBrowserAuth: false,
} }
} }