refactor: apply some suggestions from SonarQube
All checks were successful
Build / build (pull_request) Successful in 1m49s
All checks were successful
Build / build (pull_request) Successful in 1m49s
This commit is contained in:
parent
7d2cda5b20
commit
331a830c2b
5 changed files with 33 additions and 7 deletions
|
@ -17,12 +17,38 @@ class RevisionTest {
|
||||||
var r2 = new Revision();
|
var r2 = new Revision();
|
||||||
r2.rev = 1;
|
r2.rev = 1;
|
||||||
|
|
||||||
assertThat(r1).as("Revisions should be equal").isEqualTo(r2);
|
var r3 = new Revision();
|
||||||
|
r3.rev = 2;
|
||||||
|
|
||||||
|
assertThat(r1)
|
||||||
|
.as("Revisions equality should should match expected value")
|
||||||
|
.isEqualTo(r1)
|
||||||
|
.isEqualTo(r2)
|
||||||
|
.isNotEqualTo(r3)
|
||||||
|
.isNotEqualTo(new Object());
|
||||||
}
|
}
|
||||||
|
|
||||||
@Test
|
@Test
|
||||||
void testHashCode() {}
|
void testHashCode() {
|
||||||
|
var r1 = new Revision();
|
||||||
|
r1.rev = 123;
|
||||||
|
|
||||||
|
var r2 = new Revision();
|
||||||
|
r2.rev = 123;
|
||||||
|
|
||||||
|
var r3 = new Revision();
|
||||||
|
r3.rev = 2;
|
||||||
|
|
||||||
|
assertThat(r1.hashCode()).isEqualTo(123).isEqualTo(r2.hashCode()).isNotEqualTo(r3.hashCode());
|
||||||
|
}
|
||||||
|
|
||||||
@Test
|
@Test
|
||||||
void testToString() {}
|
void testToString() {
|
||||||
|
var rev = new Revision();
|
||||||
|
rev.rev = 1;
|
||||||
|
|
||||||
|
assertThat(rev.toString())
|
||||||
|
.as("Revision's toString should match expected value")
|
||||||
|
.isEqualTo("Revision{rev=1}");
|
||||||
|
}
|
||||||
}
|
}
|
||||||
|
|
|
@ -12,7 +12,7 @@ import io.restassured.http.ContentType;
|
||||||
import org.junit.jupiter.api.Test;
|
import org.junit.jupiter.api.Test;
|
||||||
|
|
||||||
@QuarkusTest
|
@QuarkusTest
|
||||||
public class ActorTest {
|
class ActorTest {
|
||||||
|
|
||||||
@InjectSpy
|
@InjectSpy
|
||||||
TracingService tracingService;
|
TracingService tracingService;
|
||||||
|
|
|
@ -12,7 +12,7 @@ import io.restassured.http.ContentType;
|
||||||
import org.junit.jupiter.api.Test;
|
import org.junit.jupiter.api.Test;
|
||||||
|
|
||||||
@QuarkusTest
|
@QuarkusTest
|
||||||
public class QueryParamTest {
|
class QueryParamTest {
|
||||||
|
|
||||||
@InjectSpy
|
@InjectSpy
|
||||||
TracingService tracingService;
|
TracingService tracingService;
|
||||||
|
|
|
@ -14,7 +14,7 @@ import org.junit.jupiter.api.Test;
|
||||||
|
|
||||||
@QuarkusTest
|
@QuarkusTest
|
||||||
@TestProfile(Test2Profile.class)
|
@TestProfile(Test2Profile.class)
|
||||||
public class RawPathTest {
|
class RawPathTest {
|
||||||
|
|
||||||
@InjectSpy
|
@InjectSpy
|
||||||
TracingService tracingService;
|
TracingService tracingService;
|
||||||
|
|
|
@ -14,7 +14,7 @@ import org.junit.jupiter.api.Test;
|
||||||
|
|
||||||
@QuarkusTest
|
@QuarkusTest
|
||||||
@TestProfile(Test2Profile.class)
|
@TestProfile(Test2Profile.class)
|
||||||
public class RedactedTest {
|
class RedactedTest {
|
||||||
|
|
||||||
@InjectSpy
|
@InjectSpy
|
||||||
TracingService tracingService;
|
TracingService tracingService;
|
||||||
|
|
Loading…
Add table
Add a link
Reference in a new issue