From 331a830c2bf92fd4e109bec88ea88cbb25910744 Mon Sep 17 00:00:00 2001
From: Jorge Bornhausen <jorge.bornhausen@phoenix-technologies.ch>
Date: Wed, 23 Jul 2025 14:27:42 +0200
Subject: [PATCH] refactor: apply some suggestions from SonarQube

---
 .../quarkus/commons/audit/RevisionTest.java   | 32 +++++++++++++++++--
 .../quarkus/commons/tracing/ActorTest.java    |  2 +-
 .../commons/tracing/QueryParamTest.java       |  2 +-
 .../quarkus/commons/tracing/RawPathTest.java  |  2 +-
 .../quarkus/commons/tracing/RedactedTest.java |  2 +-
 5 files changed, 33 insertions(+), 7 deletions(-)

diff --git a/quarkus-audit-tools/src/test/java/ch/phoenix/oss/quarkus/commons/audit/RevisionTest.java b/quarkus-audit-tools/src/test/java/ch/phoenix/oss/quarkus/commons/audit/RevisionTest.java
index 1b08c56..61c3743 100644
--- a/quarkus-audit-tools/src/test/java/ch/phoenix/oss/quarkus/commons/audit/RevisionTest.java
+++ b/quarkus-audit-tools/src/test/java/ch/phoenix/oss/quarkus/commons/audit/RevisionTest.java
@@ -17,12 +17,38 @@ class RevisionTest {
         var r2 = new Revision();
         r2.rev = 1;
 
-        assertThat(r1).as("Revisions should be equal").isEqualTo(r2);
+        var r3 = new Revision();
+        r3.rev = 2;
+
+        assertThat(r1)
+                .as("Revisions equality should should match expected value")
+                .isEqualTo(r1)
+                .isEqualTo(r2)
+                .isNotEqualTo(r3)
+                .isNotEqualTo(new Object());
     }
 
     @Test
-    void testHashCode() {}
+    void testHashCode() {
+        var r1 = new Revision();
+        r1.rev = 123;
+
+        var r2 = new Revision();
+        r2.rev = 123;
+
+        var r3 = new Revision();
+        r3.rev = 2;
+
+        assertThat(r1.hashCode()).isEqualTo(123).isEqualTo(r2.hashCode()).isNotEqualTo(r3.hashCode());
+    }
 
     @Test
-    void testToString() {}
+    void testToString() {
+        var rev = new Revision();
+        rev.rev = 1;
+
+        assertThat(rev.toString())
+                .as("Revision's toString should match expected value")
+                .isEqualTo("Revision{rev=1}");
+    }
 }
diff --git a/quarkus-tracing-service/src/test/java/ch/phoenix/oss/quarkus/commons/tracing/ActorTest.java b/quarkus-tracing-service/src/test/java/ch/phoenix/oss/quarkus/commons/tracing/ActorTest.java
index a173b72..8ab52eb 100644
--- a/quarkus-tracing-service/src/test/java/ch/phoenix/oss/quarkus/commons/tracing/ActorTest.java
+++ b/quarkus-tracing-service/src/test/java/ch/phoenix/oss/quarkus/commons/tracing/ActorTest.java
@@ -12,7 +12,7 @@ import io.restassured.http.ContentType;
 import org.junit.jupiter.api.Test;
 
 @QuarkusTest
-public class ActorTest {
+class ActorTest {
 
     @InjectSpy
     TracingService tracingService;
diff --git a/quarkus-tracing-service/src/test/java/ch/phoenix/oss/quarkus/commons/tracing/QueryParamTest.java b/quarkus-tracing-service/src/test/java/ch/phoenix/oss/quarkus/commons/tracing/QueryParamTest.java
index 7378040..10b3894 100644
--- a/quarkus-tracing-service/src/test/java/ch/phoenix/oss/quarkus/commons/tracing/QueryParamTest.java
+++ b/quarkus-tracing-service/src/test/java/ch/phoenix/oss/quarkus/commons/tracing/QueryParamTest.java
@@ -12,7 +12,7 @@ import io.restassured.http.ContentType;
 import org.junit.jupiter.api.Test;
 
 @QuarkusTest
-public class QueryParamTest {
+class QueryParamTest {
 
     @InjectSpy
     TracingService tracingService;
diff --git a/quarkus-tracing-service/src/test/java/ch/phoenix/oss/quarkus/commons/tracing/RawPathTest.java b/quarkus-tracing-service/src/test/java/ch/phoenix/oss/quarkus/commons/tracing/RawPathTest.java
index 96d8956..e3579ba 100644
--- a/quarkus-tracing-service/src/test/java/ch/phoenix/oss/quarkus/commons/tracing/RawPathTest.java
+++ b/quarkus-tracing-service/src/test/java/ch/phoenix/oss/quarkus/commons/tracing/RawPathTest.java
@@ -14,7 +14,7 @@ import org.junit.jupiter.api.Test;
 
 @QuarkusTest
 @TestProfile(Test2Profile.class)
-public class RawPathTest {
+class RawPathTest {
 
     @InjectSpy
     TracingService tracingService;
diff --git a/quarkus-tracing-service/src/test/java/ch/phoenix/oss/quarkus/commons/tracing/RedactedTest.java b/quarkus-tracing-service/src/test/java/ch/phoenix/oss/quarkus/commons/tracing/RedactedTest.java
index 34658e2..c928917 100644
--- a/quarkus-tracing-service/src/test/java/ch/phoenix/oss/quarkus/commons/tracing/RedactedTest.java
+++ b/quarkus-tracing-service/src/test/java/ch/phoenix/oss/quarkus/commons/tracing/RedactedTest.java
@@ -14,7 +14,7 @@ import org.junit.jupiter.api.Test;
 
 @QuarkusTest
 @TestProfile(Test2Profile.class)
-public class RedactedTest {
+class RedactedTest {
 
     @InjectSpy
     TracingService tracingService;
-- 
2.47.2