From 22d95c99b56cbea0dde5ca29b36439ff58daeef6 Mon Sep 17 00:00:00 2001 From: Krrish Dholakia Date: Thu, 17 Oct 2024 11:02:49 -0700 Subject: [PATCH] fix(ui_sso.py): fix faulty admin check fix check to make sure admin can log into ui in 'admin_only' ui access mode Fixes https://github.com/BerriAI/litellm/issues/6286 --- litellm/proxy/_new_secret_config.yaml | 7 ++----- litellm/proxy/management_endpoints/ui_sso.py | 2 +- 2 files changed, 3 insertions(+), 6 deletions(-) diff --git a/litellm/proxy/_new_secret_config.yaml b/litellm/proxy/_new_secret_config.yaml index 90c9fc3d98..5021d3e073 100644 --- a/litellm/proxy/_new_secret_config.yaml +++ b/litellm/proxy/_new_secret_config.yaml @@ -5,8 +5,5 @@ model_list: api_key: os.environ/OPENAI_API_KEY -assistant_settings: - custom_llm_provider: azure - litellm_params: - api_key: os.environ/AZURE_API_KEY - api_base: os.environ/AZURE_API_BASE +general_settings: + ui_access_mode: admin_only diff --git a/litellm/proxy/management_endpoints/ui_sso.py b/litellm/proxy/management_endpoints/ui_sso.py index d2b0e551ad..7f2cc1c216 100644 --- a/litellm/proxy/management_endpoints/ui_sso.py +++ b/litellm/proxy/management_endpoints/ui_sso.py @@ -547,7 +547,7 @@ async def auth_callback(request: Request): ## CHECK IF ROLE ALLOWED TO USE PROXY ## if ui_access_mode == "admin_only" and ( user_role != LitellmUserRoles.PROXY_ADMIN.value - or user_role != LitellmUserRoles.PROXY_ADMIN_VIEW_ONLY.value + and user_role != LitellmUserRoles.PROXY_ADMIN_VIEW_ONLY.value ): verbose_proxy_logger.debug("EXCEPTION RAISED") raise HTTPException(