phoenix/litellm-mirror
0
0
Fork 1
mirror of https://github.com/BerriAI/litellm.git synced 2025-04-27 03:34:10 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions

fix(caching.py): pass redis kwargs to connection pool init

Browse source
This commit is contained in:
Krrish Dholakia 2024-03-18 08:21:36 -07:00
parent 016b3c7931
commit dfcf16eb4d
2 changed files with 37 additions and 7 deletions
Download patch file Download diff file Expand all files Collapse all files

2
litellm/caching.py
View file

@ -109,7 +109,7 @@ class RedisCache(BaseCache):
redis_kwargs.update(kwargs) redis_kwargs.update(kwargs)
self.redis_client = get_redis_client(**redis_kwargs) self.redis_client = get_redis_client(**redis_kwargs)
self.redis_kwargs = redis_kwargs self.redis_kwargs = redis_kwargs
self.async_redis_conn_pool = get_redis_connection_pool() self.async_redis_conn_pool = get_redis_connection_pool(**redis_kwargs)
def init_async_client(self): def init_async_client(self):
from ._redis import get_redis_async_client from ._redis import get_redis_async_client

42
litellm/tests/test_caching.py
View file

@ -33,6 +33,41 @@ def generate_random_word(length=4):
messages = [{"role": "user", "content": "who is ishaan 5222"}] messages = [{"role": "user", "content": "who is ishaan 5222"}]
# @pytest.mark.skip(reason="")
def test_caching_dynamic_args(): # test in memory cache
try:
litellm.set_verbose = True
_redis_host_env = os.environ.pop("REDIS_HOST")
_redis_port_env = os.environ.pop("REDIS_PORT")
_redis_password_env = os.environ.pop("REDIS_PASSWORD")
litellm.cache = Cache(
type="redis",
host=_redis_host_env,
port=_redis_port_env,
password=_redis_password_env,
)
response1 = completion(model="gpt-3.5-turbo", messages=messages, caching=True)
response2 = completion(model="gpt-3.5-turbo", messages=messages, caching=True)
print(f"response1: {response1}")
print(f"response2: {response2}")
litellm.cache = None # disable cache
litellm.success_callback = []
litellm._async_success_callback = []
if (
response2["choices"][0]["message"]["content"]
!= response1["choices"][0]["message"]["content"]
):
print(f"response1: {response1}")
print(f"response2: {response2}")
pytest.fail(f"Error occurred:")
os.environ["REDIS_HOST"] = _redis_host_env
os.environ["REDIS_PORT"] = _redis_port_env
os.environ["REDIS_PASSWORD"] = _redis_password_env
except Exception as e:
print(f"error occurred: {traceback.format_exc()}")
pytest.fail(f"Error occurred: {e}")
def test_caching_v2(): # test in memory cache def test_caching_v2(): # test in memory cache
try: try:
litellm.set_verbose = True litellm.set_verbose = True
@ -549,12 +584,7 @@ async def test_redis_cache_acompletion_stream_bedrock():
"content": f"write a one sentence poem about: {random_word}", "content": f"write a one sentence poem about: {random_word}",
} }
] ]
litellm.cache = Cache( litellm.cache = Cache(type="redis")
type="redis",
host=os.environ["REDIS_HOST"],
port=os.environ["REDIS_PORT"],
password=os.environ["REDIS_PASSWORD"],
)
print("test for caching, streaming + completion") print("test for caching, streaming + completion")
response_1_content = "" response_1_content = ""
response_2_content = "" response_2_content = ""