phoenix/litellm-mirror
0
0
Fork 1
mirror of https://github.com/BerriAI/litellm.git synced 2025-04-26 19:24:27 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions

fix completion vs acompletion params

Browse source
This commit is contained in:
Ishaan Jaff 2024-05-09 07:59:37 -07:00
parent e7e54772ae
commit dfd6361310
2 changed files with 19 additions and 5 deletions
Download patch file Download diff file Expand all files Collapse all files

1
litellm/main.py
View file

@ -207,6 +207,7 @@ async def acompletion(
api_version: Optional[str] = None, api_version: Optional[str] = None,
api_key: Optional[str] = None, api_key: Optional[str] = None,
model_list: Optional[list] = None, # pass in a list of api_base,keys, etc. model_list: Optional[list] = None, # pass in a list of api_base,keys, etc.
extra_headers: Optional[dict] = None,
# Optional liteLLM function params # Optional liteLLM function params
**kwargs, **kwargs,
): ):

23
litellm/tests/test_acompletion.py
View file

@ -1,5 +1,6 @@
import pytest import pytest
from litellm import acompletion from litellm import acompletion
from litellm import completion
def test_acompletion_params(): def test_acompletion_params():
@ -7,17 +8,29 @@ def test_acompletion_params():
from litellm.types.completion import CompletionRequest from litellm.types.completion import CompletionRequest
acompletion_params_odict = inspect.signature(acompletion).parameters acompletion_params_odict = inspect.signature(acompletion).parameters
acompletion_params = {name: param.annotation for name, param in acompletion_params_odict.items()} completion_params_dict = inspect.signature(completion).parameters
completion_params = {field_name: field_type for field_name, field_type in CompletionRequest.__annotations__.items()}
# remove kwargs acompletion_params = {
acompletion_params.pop("kwargs", None) name: param.annotation for name, param in acompletion_params_odict.items()
}
completion_params = {
name: param.annotation for name, param in completion_params_dict.items()
}
keys_acompletion = set(acompletion_params.keys()) keys_acompletion = set(acompletion_params.keys())
keys_completion = set(completion_params.keys()) keys_completion = set(completion_params.keys())
print(keys_acompletion)
print("\n\n\n")
print(keys_completion)
print("diff=", keys_completion - keys_acompletion)
# Assert that the parameters are the same # Assert that the parameters are the same
if keys_acompletion != keys_completion: if keys_acompletion != keys_completion:
pytest.fail("The parameters of the acompletion function and the CompletionRequest class are not the same.") pytest.fail(
"The parameters of the litellm.acompletion function and litellm.completion are not the same."
)
# test_acompletion_params() # test_acompletion_params()