From fe9180a39d4c6df2615dc6bc1c5dc202f1c38271 Mon Sep 17 00:00:00 2001 From: Krrish Dholakia Date: Thu, 15 Feb 2024 17:48:00 -0800 Subject: [PATCH] fix(redis.py): fix instantiating redis client from url --- litellm/_redis.py | 6 ++++++ litellm/caching.py | 6 ++++-- 2 files changed, 10 insertions(+), 2 deletions(-) diff --git a/litellm/_redis.py b/litellm/_redis.py index 4484926d4b..69ff6f3f2c 100644 --- a/litellm/_redis.py +++ b/litellm/_redis.py @@ -98,6 +98,9 @@ def _get_redis_client_logic(**env_overrides): def get_redis_client(**env_overrides): redis_kwargs = _get_redis_client_logic(**env_overrides) if "url" in redis_kwargs and redis_kwargs["url"] is not None: + redis_kwargs.pop( + "connection_pool", None + ) # redis.from_url doesn't support setting your own connection pool return redis.Redis.from_url(**redis_kwargs) return redis.Redis(**redis_kwargs) @@ -105,6 +108,9 @@ def get_redis_client(**env_overrides): def get_redis_async_client(**env_overrides): redis_kwargs = _get_redis_client_logic(**env_overrides) if "url" in redis_kwargs and redis_kwargs["url"] is not None: + redis_kwargs.pop( + "connection_pool", None + ) # redis.from_url doesn't support setting your own connection pool return async_redis.Redis.from_url(**redis_kwargs) return async_redis.Redis( socket_timeout=5, diff --git a/litellm/caching.py b/litellm/caching.py index 5649720680..307bc20ae2 100644 --- a/litellm/caching.py +++ b/litellm/caching.py @@ -134,10 +134,12 @@ class RedisCache(BaseCache): f"Set ASYNC Redis Cache: key: {key}\nValue {value}\nttl={ttl}" ) try: - await redis_client.set(name=key, value=json.dumps(value), ex=ttl) + await redis_client.set( + name=key, value=json.dumps(value), ex=ttl, get=True + ) except Exception as e: # NON blocking - notify users Redis is throwing an exception - logging.debug("LiteLLM Caching: set() - Got exception from REDIS : ", e) + print_verbose("LiteLLM Caching: set() - Got exception from REDIS : ", e) async def async_set_cache_pipeline(self, cache_list, ttl=None): """