From 1ab886f80dd0d8ca831a9b4a77ad42c88d91ff88 Mon Sep 17 00:00:00 2001 From: Ishaan Jaff Date: Thu, 3 Oct 2024 04:42:34 -0700 Subject: [PATCH] (contributor PRs) oct 3rd, 2024 (#6034) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit * Do not skip important tests for OIDC. (#6017) * [Bug] Skip monthly slack alert if there was no spend (#6015) * Fix: skip slack alert if there was no spend * Skip monthly report when there was no spend --------- Co-authored-by: María Paz Cuturi --------- Co-authored-by: David Manouchehri Co-authored-by: Paz Co-authored-by: María Paz Cuturi --- litellm/integrations/SlackAlerting/slack_alerting.py | 2 +- tests/local_testing/test_embedding.py | 1 - 2 files changed, 1 insertion(+), 2 deletions(-) diff --git a/litellm/integrations/SlackAlerting/slack_alerting.py b/litellm/integrations/SlackAlerting/slack_alerting.py index 34aba36a2..f9de9adcd 100644 --- a/litellm/integrations/SlackAlerting/slack_alerting.py +++ b/litellm/integrations/SlackAlerting/slack_alerting.py @@ -1644,7 +1644,7 @@ Model Info: end_date=last_day_of_month.strftime("%Y-%m-%d"), ) - if _resp is None: + if _resp is None or _resp == ([], []): return monthly_spend_per_team, monthly_spend_per_tag = _resp diff --git a/tests/local_testing/test_embedding.py b/tests/local_testing/test_embedding.py index 949052ab7..4c7560ccc 100644 --- a/tests/local_testing/test_embedding.py +++ b/tests/local_testing/test_embedding.py @@ -316,7 +316,6 @@ def test_openai_azure_embedding(): os.environ.get("CIRCLE_OIDC_TOKEN") is None, reason="Cannot run without being in CircleCI Runner", ) -@pytest.mark.skip(reason="Azure east us 2 has a temp outage") def test_openai_azure_embedding_with_oidc_and_cf(): # TODO: Switch to our own Azure account, currently using ai.moda's account os.environ["AZURE_TENANT_ID"] = "17c0a27a-1246-4aa1-a3b6-d294e80e783c"