phoenix/litellm
1
0
Fork 0
forked from phoenix/litellm-mirror
Code Pull requests Activity

fix(utils.py): ignore none chunk in stream infinite loop check

Browse source 
Fixes https://github.com/BerriAI/litellm/issues/5158#issuecomment-2287156946
This commit is contained in:
Krrish Dholakia 2024-08-13 15:06:31 -07:00
parent b24da18d2d
commit 3a1b3227d8
2 changed files with 24 additions and 11 deletions
Download patch file Download diff file Expand all files Collapse all files

14
litellm/tests/test_streaming.py
View file

@ -3251,7 +3251,13 @@ def test_unit_test_custom_stream_wrapper():
litellm.REPEATED_STREAMING_CHUNK_LIMIT - 1, litellm.REPEATED_STREAMING_CHUNK_LIMIT - 1,
], ],
) )
def test_unit_test_custom_stream_wrapper_repeating_chunk(loop_amount): @pytest.mark.parametrize(
"chunk_value, expected_chunk_fail",
[("How are you?", True), ("{", False), ("", False), (None, False)],
)
def test_unit_test_custom_stream_wrapper_repeating_chunk(
loop_amount, chunk_value, expected_chunk_fail
):
""" """
Test if InternalServerError raised if model enters infinite loop Test if InternalServerError raised if model enters infinite loop
@ -3269,7 +3275,7 @@ def test_unit_test_custom_stream_wrapper_repeating_chunk(loop_amount):
"choices": [ "choices": [
{ {
"index": 0, "index": 0,
"delta": {"content": "How are you?"}, "delta": {"content": chunk_value},
"finish_reason": "stop", "finish_reason": "stop",
} }
], ],
@ -3294,7 +3300,9 @@ def test_unit_test_custom_stream_wrapper_repeating_chunk(loop_amount):
), ),
) )
if loop_amount > litellm.REPEATED_STREAMING_CHUNK_LIMIT: print(f"expected_chunk_fail: {expected_chunk_fail}")
if (loop_amount > litellm.REPEATED_STREAMING_CHUNK_LIMIT) and expected_chunk_fail:
with pytest.raises(litellm.InternalServerError): with pytest.raises(litellm.InternalServerError):
for chunk in response: for chunk in response:
continue continue

5
litellm/utils.py
View file

@ -8662,6 +8662,11 @@ class CustomStreamWrapper:
# Check if all extracted contents are identical # Check if all extracted contents are identical
if all(content == last_contents[0] for content in last_contents): if all(content == last_contents[0] for content in last_contents):
if (
last_contents[0] is not None
and isinstance(last_contents[0], str)
and len(last_contents[0]) > 2
): # ignore empty content - https://github.com/BerriAI/litellm/issues/5158#issuecomment-2287156946
# All last n chunks are identical # All last n chunks are identical
raise litellm.InternalServerError( raise litellm.InternalServerError(
message="The model is repeating the same chunk = {}.".format( message="The model is repeating the same chunk = {}.".format(