phoenix/litellm
1
0
Fork 0
forked from phoenix/litellm-mirror
Code Pull requests Activity

fix test_get_gcs_logging_config_without_service_account

Browse source
This commit is contained in:
Ishaan Jaff 2024-11-06 18:27:36 -08:00
parent 373f9d409e
commit 5713f3b5d7
1 changed files with 4 additions and 4 deletions
Download patch file Download diff file Expand all files Collapse all files

4
tests/local_testing/test_gcs_bucket.py
View file

@ -528,6 +528,8 @@ async def test_get_gcs_logging_config_without_service_account():
1. Key based logging without a service account
2. Default Callback without a service account
"""
_old_gcs_bucket_name = os.environ.get("GCS_BUCKET_NAME")
os.environ.pop("GCS_BUCKET_NAME")
# Mock the load_auth function to avoid credential loading issues
# Test 1: With standard_callback_dynamic_params (with service account)
@ -559,8 +561,6 @@ async def test_get_gcs_logging_config_without_service_account():
# Test 5: With missing bucket name
with pytest.raises(ValueError, match="GCS_BUCKET_NAME is not set"):
_old_gcs_bucket_name = os.environ.get("GCS_BUCKET_NAME")
os.environ.pop("GCS_BUCKET_NAME")
gcs_logger = GCSBucketLogger(bucket_name=None)
await gcs_logger.get_gcs_logging_config({})