From c6da749997019b6b6204dcff23cc0ee242058bad Mon Sep 17 00:00:00 2001 From: Ishaan Jaff Date: Wed, 6 Nov 2024 20:49:44 -0800 Subject: [PATCH] fix test_get_gcs_logging_config_without_service_account --- tests/local_testing/test_gcs_bucket.py | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/tests/local_testing/test_gcs_bucket.py b/tests/local_testing/test_gcs_bucket.py index f7cbff809..fed287bd0 100644 --- a/tests/local_testing/test_gcs_bucket.py +++ b/tests/local_testing/test_gcs_bucket.py @@ -531,6 +531,9 @@ async def test_get_gcs_logging_config_without_service_account(): _old_gcs_bucket_name = os.environ.get("GCS_BUCKET_NAME") os.environ.pop("GCS_BUCKET_NAME") + _old_gcs_service_acct = os.environ.get("GCS_PATH_SERVICE_ACCOUNT") + os.environ.pop("GCS_PATH_SERVICE_ACCOUNT") + # Mock the load_auth function to avoid credential loading issues # Test 1: With standard_callback_dynamic_params (with service account) gcs_logger = GCSBucketLogger() @@ -566,3 +569,6 @@ async def test_get_gcs_logging_config_without_service_account(): if _old_gcs_bucket_name is not None: os.environ["GCS_BUCKET_NAME"] = _old_gcs_bucket_name + + if _old_gcs_service_acct is not None: + os.environ["GCS_PATH_SERVICE_ACCOUNT"] = _old_gcs_service_acct