phoenix-oss/llama-stack-mirror
0
0
Fork 1
mirror of https://github.com/meta-llama/llama-stack.git synced 2025-10-04 04:04:14 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions

Address PR feedback: optimize logging and encapsulate document_id access

Browse source 
- Gate debug logging behind isEnabledFor check to avoid unnecessary computation
- Add Chunk.document_id property to safely handle metadata/chunk_metadata extraction
- Simplify RAG memory code using new property
This commit is contained in:
skamenan7 2025-09-24 16:07:47 -04:00
parent a14f79a362
commit 2510bd349e
3 changed files with 24 additions and 11 deletions
Download patch file Download diff file Expand all files Collapse all files

5
llama_stack/providers/inline/tool_runtime/rag/memory.py
View file

@ -279,10 +279,7 @@ class MemoryToolRuntimeImpl(ToolGroupsProtocolPrivate, ToolRuntime, RAGToolRunti
return RAGQueryResult(
content=picked,
metadata={
"document_ids": [
c.metadata.get("document_id") or (c.chunk_metadata.document_id if c.chunk_metadata else None)
for c in chunks[: len(picked)]
],
"document_ids": [c.document_id for c in chunks[: len(picked)]],
"chunks": [c.content for c in chunks[: len(picked)]],
"scores": scores[: len(picked)],
"vector_db_ids": [c.metadata["vector_db_id"] for c in chunks[: len(picked)]],