phoenix-oss/llama-stack-mirror
0
0
Fork 1
mirror of https://github.com/meta-llama/llama-stack.git synced 2025-12-03 09:53:45 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions

revert(debug): Remove temporary debug logging from resolver

Browse source 
Removing the debug logging that was added to diagnose signature mismatch errors.
The logging served its purpose - it helped us identify that the error was coming
from api_recorder.py patched methods, not the actual provider implementations.

With the root cause now fixed in api_recorder.py, this debug logging is no longer
needed and can be safely removed to keep the code clean.
This commit is contained in:
Omar Abdelwahab 2025-11-12 16:12:14 -08:00
parent 4a1fa139f1
commit c0295a2495
1 changed files with 0 additions and 5 deletions
Download patch file Download diff file Expand all files Collapse all files

5
src/llama_stack/core/resolver.py
View file

@ -451,11 +451,6 @@ def check_protocol_compliance(obj: Any, protocol: Any) -> None:
obj_params.discard("self") obj_params.discard("self")
if not (proto_params <= obj_params): if not (proto_params <= obj_params):
logger.error(f"Method {name} incompatible proto: {proto_params} vs. obj: {obj_params}") logger.error(f"Method {name} incompatible proto: {proto_params} vs. obj: {obj_params}")
logger.error(f"Provider: {obj.__class__.__name__} from module {obj.__class__.__module__}")
logger.error(f"Protocol signature: {proto_sig}")
logger.error(f"Object signature: {obj_sig}")
logger.error(f"Object method: {obj_method}")
logger.error(f"Object method's module: {inspect.getmodule(obj_method)}")
missing_methods.append((name, "signature_mismatch")) missing_methods.append((name, "signature_mismatch"))
else: else:
# Check if the method has a concrete implementation (not just a protocol stub) # Check if the method has a concrete implementation (not just a protocol stub)