phoenix-oss/quarkus-commons
3
0
Fork 0
Code Issues 1 Pull requests 1 Projects Releases Packages 27 Wiki Activity Actions

feat: add quarkus-db-management-junit-extension from existing phoenix-oss/junit-database-cleanup-extension #184

Open
jorge.bornhausen wants to merge 24 commits from db-extension into main
pull from: db-extension
merge into: phoenix-oss:main
Conversation 3 Commits 24 Files changed 21 +380 -15
jorge.bornhausen commented 2026-03-26 21:47:32 +00:00
Owner
Copy link

@pawel.derehajlo let me know what you think, used git subtree to keep all the commit history from the original repo

@pawel.derehajlo let me know what you think, used git subtree to keep all the commit history from the original repo
modified pom.xml so that this project can be released
git-subtree-dir: junit-database-cleanup-extension
git-subtree-mainline: 44aac28ef5
git-subtree-split: 74a191d19a
pawel.derehajlo commented 2026-03-27 08:19:41 +00:00
Member
Copy link

@jorge.bornhausen I am moving actions to their own repository so let me finish that so this repo can already use them

@jorge.bornhausen I am moving actions to their own repository so let me finish that so this repo can already use them
jorge.bornhausen commented 2026-03-27 20:55:04 +00:00
Author
Owner
Copy link

@pawel.derehajlo in the scope of this pull request I wouldn't include the actions changes, let's do that separately. However, what would make sense here is to add a couple test classes, one for each db cleanup method, so we can make sure it works. I mention this because I installed it locally and tried to refactor the portal to import this module, but I eventually ran into issues with quarkus restarts and multiple sessions open thus a SQL error happens. It would be interesting to know what is causing this, if it was an error in the migration of this module, if it's the bump in quarkus version on this repo, or something else entirely.

@pawel.derehajlo in the scope of this pull request I wouldn't include the actions changes, let's do that separately. However, what would make sense here is to add a couple test classes, one for each db cleanup method, so we can make sure it works. I mention this because I installed it locally and tried to refactor the portal to import this module, but I eventually ran into issues with quarkus restarts and multiple sessions open thus a SQL error happens. It would be interesting to know what is causing this, if it was an error in the migration of this module, if it's the bump in quarkus version on this repo, or something else entirely.
chore: cleanup in quarkus-db-management-junit-extension and improved comments and readme
All checks were successful
Build / build (pull_request) Successful in 2m17s
Details
7e7f064b03
pawel.derehajlo commented 2026-03-30 11:59:22 +00:00
Member
Copy link

I am adding some tests

I am adding some tests
🚀 1
All checks were successful
Build / build (pull_request) Successful in 2m17s
Required
Details
This pull request has changes conflicting with the target branch.
  • .gitattributes
  • pom.xml
  • quarkus-audit-tools/pom.xml
  • quarkus-client-logger/pom.xml
  • quarkus-clock-service/pom.xml
  • quarkus-forgejo-client/pom.xml
  • quarkus-json-service/pom.xml
  • quarkus-litellm-client/pom.xml
  • quarkus-message-digest-service/pom.xml
  • quarkus-random-number-generator/pom.xml
  • quarkus-table-generator/pom.xml
  • quarkus-tracing-service/pom.xml
  • quarkus-uuid-generator/pom.xml
View command line instructions

Manual merge helper

Use this merge commit message when completing the merge manually.

Checkout

From your project repository, check out a new branch and test the changes.
git fetch -u origin db-extension:db-extension
git switch db-extension
Sign in to join this conversation.
Reviewers
No reviewers
michal.tumilowicz
joseluis.gutierrez
pawel.derehajlo
roque.caballero
humberto.casanova
Labels
Clear labels
No items
No labels
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
2 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
phoenix-oss/quarkus-commons!184
No description provided.