(contributor PRs) oct 3rd, 2024 (#6034)

* Do not skip important tests for OIDC. (#6017)

* [Bug] Skip monthly slack alert if there was no spend (#6015)

* Fix: skip slack alert if there was no spend

* Skip monthly report when there was no spend

---------

Co-authored-by: María Paz Cuturi <paz@MacBook-Pro-de-Paz.local>

---------

Co-authored-by: David Manouchehri <david.manouchehri@ai.moda>
Co-authored-by: Paz <paz@tryolabs.com>
Co-authored-by: María Paz Cuturi <paz@MacBook-Pro-de-Paz.local>
This commit is contained in:
Ishaan Jaff 2024-10-03 04:42:34 -07:00 committed by GitHub
parent d92696a303
commit 1ab886f80d
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
2 changed files with 1 additions and 2 deletions

View file

@ -1644,7 +1644,7 @@ Model Info:
end_date=last_day_of_month.strftime("%Y-%m-%d"),
)
if _resp is None:
if _resp is None or _resp == ([], []):
return
monthly_spend_per_team, monthly_spend_per_tag = _resp

View file

@ -316,7 +316,6 @@ def test_openai_azure_embedding():
os.environ.get("CIRCLE_OIDC_TOKEN") is None,
reason="Cannot run without being in CircleCI Runner",
)
@pytest.mark.skip(reason="Azure east us 2 has a temp outage")
def test_openai_azure_embedding_with_oidc_and_cf():
# TODO: Switch to our own Azure account, currently using ai.moda's account
os.environ["AZURE_TENANT_ID"] = "17c0a27a-1246-4aa1-a3b6-d294e80e783c"